Summary: | Relocate track_login call in Auth.pm (see 22543) | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Authentication | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, dpavlin, jonathan.druart, lucas, martin.renvoize, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.06, 19.11.12
|
|
Circulation function: | |||
Bug Depends on: | 22543 | ||
Bug Blocks: | |||
Attachments: |
Bug 26191: Relocate track_login call in Auth.pm
Bug 26191: Relocate track_login call in Auth.pm |
Description
Marcel de Rooy
2020-08-11 11:21:23 UTC
Created attachment 108052 [details] [review] Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Still applies, taking liberty to self signoff before we can also rebase this one liner ;) Created attachment 111243 [details] [review] Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Passing QA, patch is clear and simple and works as expected. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.06 backported to 19.11.x for 19.11.12 Missing dependencies for 19.05.x, shouldn't affect it. |