| Summary: | Remove the use of jquery.checkboxes plugin when adding orders from MARC file | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | aleisha, amit.gupta, amitddng135, lucas, testopia, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04, 19.11.10
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 26006 | ||
| Attachments: |
Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file
Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file |
||
|
Description
Owen Leonard
2020-08-14 14:17:28 UTC
Created attachment 108286 [details] [review] Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file This patch removes the use of the jquery.checkboxes plugin from the page for adding orders to a basket from a staged MARC file. This patch fixes an unreported bug wherein the "select all" and "clear all" controls affected not only MARC record checkboxes but also the "show inactive funds" checkboxes. To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. Created attachment 108410 [details] [review] Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. ---------------------------- Tested and working OK. Created attachment 108420 [details] [review] Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file This patch removes the use of the jquery.checkboxes plugin from the page for adding orders to a basket from a staged MARC file. This patch fixes an unreported bug wherein the "select all" and "clear all" controls affected not only MARC record checkboxes but also the "show inactive funds" checkboxes. To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 backported to 19.11.x for 19.11.10 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |