Bug 26223

Created attachment 108381 [details] [review]
Bug 26223: include item information in OPAC ISBD view

The ISBD view in the OPAC interface does not display item information.

This patch fixes that.

Test plan:
0) Have a biblio with at least one item attached to it and include one
   of the following snippets in the OPACISBD system preference,
   depending on your MARC flavour:

   MARC21:
   #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving
   location</th><th>Koha item type</th><th>Barcode</th><th>Call number
   (Full call number)</th><th>Materials specified (bound volume or
   other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y}
   </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table>

   UNIMARC:
   #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving
   location</th><th>Koha collection</th><th>Barcode</th><th>Call number
   (Full call number)</th><th>Numbering (volume or other part)</th>|
   <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f}
   </td><td> {995k} </td><td> {995l}</td></tr>|</table>

   Switch to the OPAC ISBD view for your biblio; notice how it does
   not display item information.
1) Apply the patch, and restart Plack/memcached if necessary.
2) Refresh the OPAC ISBD view page, this time you should see item
   information as per the OPACISBD system preference setting.

This patch doesn't work ...

Does the information just not show?

(In reply to Katrin Fischer from comment #5)
> Does the information just not show?

yes

(In reply to Ivan Dziuba from comment #4)
> This patch doesn't work ...
(In reply to Ivan Dziuba from comment #6)
> (In reply to Katrin Fischer from comment #5)
> > Does the information just not show?
> 
> yes
Hi Ivan! I just tried to apply the patch on top of the current master
(51fd1db) and it worked fine. I'm not sure why it didn't work for you,
can you elaborate on what steps you followed, please?

I'm setting the status to 'Needs Signoff' to get more eyes on this...

Sorry this doesn't work for me either :(

I applied the patch, modified the OPACISBD system preference, "restart_all," and refreshed the page in the OPAC. No item information shows on the page.

I think this is caused by Bug 22696

We should come back to calling :
my $record = GetMarcBiblio({
    biblionumber => $biblionumber,
    embed_items  => 1,
    opac         => 1,
    borcat       => $borcat });

Like for example in opac-export.pl :
https://git.koha-community.org/Koha-community/Koha/src/branch/20.11.x/opac/opac-export.pl#L51

This patch is working for me.

1. Use KTD
2. Edit OPACISBD and add the following content at the end:

#952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table>

3. /cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=11

With this patch I see the table: https://snipboard.io/usn5j7.jpg

Created attachment 124099 [details] [review]
Bug 26223: include item information in OPAC ISBD view

The ISBD view in the OPAC interface does not display item information.

This patch fixes that.

Test plan:
0) Have a biblio with at least one item attached to it and include one
   of the following snippets in the OPACISBD system preference,
   depending on your MARC flavour:

   MARC21:
   #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving
   location</th><th>Koha item type</th><th>Barcode</th><th>Call number
   (Full call number)</th><th>Materials specified (bound volume or
   other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y}
   </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table>

   UNIMARC:
   #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving
   location</th><th>Koha collection</th><th>Barcode</th><th>Call number
   (Full call number)</th><th>Numbering (volume or other part)</th>|
   <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f}
   </td><td> {995k} </td><td> {995l}</td></tr>|</table>

   Switch to the OPAC ISBD view for your biblio; notice how it does
   not display item information.
1) Apply the patch, and restart Plack/memcached if necessary.
2) Refresh the OPAC ISBD view page, this time you should see item
   information as per the OPACISBD system preference setting.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

It seems to me that the order in which the filters are listed should be swapped. We want the items to be embedded and THEN their subfields filtered.

Well, and I would do:

my @items = $biblio->items->filter_by_visible_in_opac;

it will save lots of CPU cycles in some cases.

Created attachment 124101 [details] [review]
Bug 26223: include item information in OPAC ISBD view

The ISBD view in the OPAC interface does not display item information.

This patch fixes that.

Test plan:
0) Have a biblio with at least one item attached to it and include one
   of the following snippets in the OPACISBD system preference,
   depending on your MARC flavour:

   MARC21:
   #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving
   location</th><th>Koha item type</th><th>Barcode</th><th>Call number
   (Full call number)</th><th>Materials specified (bound volume or
   other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y}
   </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table>

   UNIMARC:
   #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving
   location</th><th>Koha collection</th><th>Barcode</th><th>Call number
   (Full call number)</th><th>Numbering (volume or other part)</th>|
   <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f}
   </td><td> {995k} </td><td> {995l}</td></tr>|</table>

   Switch to the OPAC ISBD view for your biblio; notice how it does
   not display item information.
1) Apply the patch, and restart Plack/memcached if necessary.
2) Refresh the OPAC ISBD view page, this time you should see item
   information as per the OPACISBD system preference setting.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Created attachment 124103 [details] [review]
Bug 26223: (QA follow-up) Fix filter order

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Pushed to master for 21.11, thanks to everybody involved!

Pushed to 21.05.x for 21.05.04

Pushed to 20.11.x for 20.11.10

Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.