Summary: | Prevent double submit of header checkin form | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, andrew, gmcharlt, kyle.m.hall, lucas, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.05, 19.11.11, 19.05.17
|
|
Circulation function: | |||
Bug Depends on: | 26136 | ||
Bug Blocks: | |||
Attachments: |
Bug 26224: Prevent double submit of header check in form
Bug 26224: Prevent double submit of header check in form Bug 26224: Prevent double submit of header check in form |
Description
Nick Clemens (kidclamp)
2020-08-17 10:15:41 UTC
Created attachment 108390 [details] [review] Bug 26224: Prevent double submit of header check in form To test: 1 - Browse to Home 1 - In the header bar select the 'Check in' tab 2 - Type a barcode into the box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah! Created attachment 110647 [details] [review] Bug 26224: Prevent double submit of header check in form To test: 1 - Browse to Home 1 - In the header bar select the 'Check in' tab 2 - Type a barcode into the box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Just a note I had to clear my cache after applying patch to get the behavior to change. Created attachment 110691 [details] [review] Bug 26224: Prevent double submit of header check in form To test: 1 - Browse to Home 1 - In the header bar select the 'Check in' tab 2 - Type a barcode into the box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.05 backported to 19.11.x for 19.11.11 Backported to 19.05.x branch for 19.05.17 |