| Summary: | Move translatable strings out of categories.tt and into categories.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | f.demians, lucas, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21156 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 26229: Move translatable strings out of categories.tt and into categories.js
Bug 26229: Move translatable strings out of categories.tt and into categories.js Bug 26229: Move translatable strings out of categories.tt and into categories.js |
||
|
Description
Owen Leonard
2020-08-17 14:32:09 UTC
Created attachment 108401 [details] [review] Bug 26229: Move translatable strings out of categories.tt and into categories.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Patron categories - Click "New category" - Enter some special characters in the "Category code" field, e.g. "%^&*" - Try to submit the form without filling in any other details. - The category code field should have a validation message, "Category code can only contain the following characters: letters, numbers, - and _." - The enrollment period fields should have a validation message, "Please choose an enrollment period in months OR by date." - Enter valid data and confirm that the form can be submitted. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/categories.js for translation, e.g.: msgid "Please choose an enrollment period in months OR by date." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Created attachment 110816 [details] [review] Bug 26229: Move translatable strings out of categories.tt and into categories.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Patron categories - Click "New category" - Enter some special characters in the "Category code" field, e.g. "%^&*" - Try to submit the form without filling in any other details. - The category code field should have a validation message, "Category code can only contain the following characters: letters, numbers, - and _." - The enrollment period fields should have a validation message, "Please choose an enrollment period in months OR by date." - Enter valid data and confirm that the form can be submitted. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/categories.js for translation, e.g.: msgid "Please choose an enrollment period in months OR by date." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Created attachment 110823 [details] [review] Bug 26229: Move translatable strings out of categories.tt and into categories.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Patron categories - Click "New category" - Enter some special characters in the "Category code" field, e.g. "%^&*" - Try to submit the form without filling in any other details. - The category code field should have a validation message, "Category code can only contain the following characters: letters, numbers, - and _." - The enrollment period fields should have a validation message, "Please choose an enrollment period in months OR by date." - Enter valid data and confirm that the form can be submitted. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/categories.js for translation, e.g.: msgid "Please choose an enrollment period in months OR by date." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Owen, just a note: When the error message for 'month or date' appears it pushes the calendar icon after the error message. This is before and after the patch, so unrelated. But do we consider this a bug? Pushed to master for 20.11, thanks to everybody involved! This patch does not apply clean to 20.05.x, no backport If needed please rebase |