Summary: | log viewer does not translate the interface properly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, fridolin.somers, lucas, martin.renvoize, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04, 19.11.10
|
|
Circulation function: | |||
Attachments: |
Bug 25872: Fix translating interface from DB term to readable term
Bug 25872: Fix translating interface from DB term to readable term Bug 25872: Fix translating interface from DB term to readable term Bug 26236: Fix translating interface from DB term to readable term |
Description
Jonathan Druart
2020-08-18 13:28:13 UTC
Created attachment 108506 [details] [review] Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Created attachment 109586 [details] [review] Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly https://bugs.koha-community.org/show_bug.cgi?id=26236 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Good catch ;) Created attachment 109595 [details] [review] Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 109596 [details] [review] Bug 26236: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, simple fix. I corrected the bug number in the commit message to match the bug here. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 backported to 19.11.x for 19.11.10 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |