| Summary: | Remove unused routines from svc/split_callnumbers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04
|
|
| Circulation function: | |||
| Attachments: |
Bug 26251: Remove unused routines from svc/split_callnumbers
Bug 26251: Remove unused routines from svc/split_callnumbers Bug 26251: Remove unused routines from svc/split_callnumbers |
||
|
Description
Marcel de Rooy
2020-08-19 11:44:52 UTC
Created attachment 108589 [details] [review] Bug 26251: Remove unused routines from svc/split_callnumbers This is just a copy and paste from svc/localization Test plan: Read the code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Jonathan, please have a look at the code you introduced? Oops, thanks Marcel. There is a use of from_json however, we should not remove the use statement. Created attachment 108624 [details] [review] Bug 26251: Remove unused routines from svc/split_callnumbers This is just a copy and paste from svc/localization Test plan: Read the code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Jonathan Druart from comment #3) > There is a use of from_json however, we should not remove the use statement. Ah. No warn from qa tools.. Fixed Created attachment 108631 [details] [review] Bug 26251: Remove unused routines from svc/split_callnumbers This is just a copy and paste from svc/localization Test plan: Read the code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 enhancement, not backported to 19.11.x |