Bug 26259

Summary: Redundant restriction alert in circulation.pl
Product: Koha Reporter: Christopher Brannon <cbrannon>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Multiple restriction alerts and punctuation inconsistencies

Description Christopher Brannon 2020-08-19 21:13:31 UTC
When checking out items with a restriction override, there seems to be a redundancy in alerts about restrictions:

Patron is restricted
Patron's card is expired
Patron has an indefinite restriction.
Restriction overridden temporarily.

I am not sure why staff need to be told twice, let alone 3 times about a restriction.  If we are overriding a restriction, it is given there is a restriction.  If a patron has an indefinite restriction, it is given there is a restriction.

This should have really told me:

Patron's card is expired
Restriction(s) overridden temporarily

I am also seeing inconsistencies in punctuation.  Should the alerts end with a period or not?
Comment 1 Christopher Brannon 2020-08-19 21:14:38 UTC
Created attachment 108702 [details]
Multiple restriction alerts and punctuation inconsistencies