Summary: | Style error on OPAC search results when item-level_itypes is set to bibliographic | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 25242 | ||
Bug Blocks: | |||
Attachments: |
Screenshot of result list with bibliographic level item type showing
Bug 26263: Add column width to itypecol |
Description
Katrin Fischer
2020-08-20 22:54:33 UTC
Created attachment 108771 [details]
Screenshot of result list with bibliographic level item type showing
Created attachment 108833 [details] [review] Bug 26263: Add column width to itypecol We add a static width to the itypecol and set a matching max-width for the contained image to improve the layout of the results table for accessability and reactivity. This patch has the side effect of enforcing a max-width on the item type icon images people are using.. I feel this is a reasonable caveat, but I'm not entirely sure how much those icons are customised or whether those that are customising them are using much larger sizes that may not scale down well? I think what this bug shows is that Bug 25242 was too wide-reaching. I think it should be reconsidered. (In reply to Owen Leonard from comment #5) > I think what this bug shows is that Bug 25242 was too wide-reaching. I think > it should be reconsidered. I agree, we should reconsider - can we limit the effect to details? Marking as resolved as we reverted. Note.. I still think the colwidth is better with this patch even with prior patch reverted.. |