|
Description
Timothy Alexis Vass
2020-08-21 10:12:54 UTC
Created attachment 108800 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. (In reply to Timothy Alexis Vass from comment #1) > Created attachment 108800 [details] [review] [review] > Bug 26266: Add jQuery validator to opac-password-recovery.tt > > To test: > 1) Initiate password recovery. > 2) Try to enter an invalid password. > 3) Confirm that validation occurs. > 4) Try to enter mismatching passwords. > 5) Confirm that validation occurs. > 6) Sign off. Hi Timothy, I have applied the patch and not find any validation while entering the mismatch password. Created attachment 108972 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Created attachment 108974 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Created attachment 108975 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. I'm sorry for attaching so many patches... This one is correct. I think this needs rebasing since bug 23816 was pushed. I had a go, but I'm not close enough to this area of code to be confident. Looks like a reasonable idea though, happy to test when it's ready :) Created attachment 110312 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 0) Activate password reset in system preferences. 1) Initiate a password recovery. 2) Try to submit with an invalid password. 3) Confirm that validation occurs. 4) Try to submit with mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Created attachment 110589 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 0) Activate password reset in system preferences. 1) Initiate a password recovery. 2) Try to submit with an invalid password. 3) Confirm that validation occurs. 4) Try to submit with mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 110592 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 0) Activate password reset in system preferences. 1) Initiate a password recovery. 2) Try to submit with an invalid password. 3) Confirm that validation occurs. 4) Try to submit with mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works as expected, no regressions found.. Passing QA Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |