|
Description
Theodoros Theodoropoulos
2020-08-21 10:45:03 UTC
Created attachment 108803 [details] Circulation Overdues report page with results Circulation Overdues report page with results from Koha DEMO installation (running master). URL: http://koha.adminkuhn.ch:8080/cgi-bin/koha/circ/overdue.pl Created attachment 108804 [details]
Contents of generated .csv file
Contents of generated .csv file when "Download file of displayed overdues" was selected
The last test was performed with koha.adminkuhn.ch (running 20.05.00.000) on 21/08/2020 and the issue was still valid Created attachment 130166 [details] [review] MT28016: "Date due to" and "Show any items currently checked out" filters doesn't work properly in overdues.pl Filter "Date due to" is now taken into account even when filled with a future date for the displayed result and downloaded results. Filter "Show any items currently checked out" is now taken into account for the downloaded results. To test: 1- Go to Circulation then to overdues 2a- Add a filter with "Date due To" > today 2b- Check that only the results with "Due date" < today are displayed (not those with "Due date" between today and the date requested) 2c- Click on "Download file of displayed overdues" 2d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 3a- Reset filter and then add the filter "Show any items currently checked out" 3b- Check that all the results are displayed (even those with "Due date" > today) 3c- Click on "Download file of displayed overdues" 3d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 9- Apply the patch 10- Repeat step 1 to 8, checking that all the results corresponding to the selected filter are now displayed/downloaded Created attachment 130204 [details] [review] MT28016: "Date due to" and "Show any items currently checked out" filters doesn't work properly in overdues.pl Filter "Date due to" is now taken into account even when filled with a future date for the displayed result and downloaded results. Filter "Show any items currently checked out" is now taken into account for the downloaded results. To test: 1- Go to Circulation then to overdues 2a- Add a filter with "Date due To" > today 2b- Check that only the results with "Due date" < today are displayed (not those with "Due date" between today and the date requested) 2c- Click on "Download file of displayed overdues" 2d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 3a- Reset filter and then add the filter "Show any items currently checked out" 3b- Check that all the results are displayed (even those with "Due date" > today) 3c- Click on "Download file of displayed overdues" 3d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 9- Apply the patch 10- Repeat step 1 to 8, checking that all the results corresponding to the selected filter are now displayed/downloaded https://bugs.koha-community.org/show_bug.cgi?id=26269 Signed-off-by: Theodoros Theodoropoulos <theod@lib.auth.gr> Patch provided by Marion seems to do the trick! Thank you BibLibre :) This is an older patch now already, but please remember that patch files always need to start with Bug XXXX: Created attachment 131148 [details] [review] Bug 26269: "Date due to" and "Show any items currently checked out" filters doesn't work properly in overdues.pl Filter "Date due to" is now taken into account even when filled with a future date for the displayed result and downloaded results. Filter "Show any items currently checked out" is now taken into account for the downloaded results. To test: 1- Go to Circulation then to overdues 2a- Add a filter with "Date due To" > today 2b- Check that only the results with "Due date" < today are displayed (not those with "Due date" between today and the date requested) 2c- Click on "Download file of displayed overdues" 2d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 3a- Reset filter and then add the filter "Show any items currently checked out" 3b- Check that all the results are displayed (even those with "Due date" > today) 3c- Click on "Download file of displayed overdues" 3d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 9- Apply the patch 10- Repeat step 1 to 8, checking that all the results corresponding to the selected filter are now displayed/downloaded https://bugs.koha-community.org/show_bug.cgi?id=26269 Signed-off-by: Theodoros Theodoropoulos <theod@lib.auth.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Marion great work, you are Theodoros goddess ;) Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.04 Pushed to 21.05.x for 21.05.13 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |