Summary: | dateexpiry and dateenrolled are missing in the new modal for BorrowerMandatoryField and others | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, gmcharlt, julian.maurice, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds the dateenrolled and dateexpiry fields to the list of fields that can be selected in system preferences such as the BorrowerMandatoryField.
|
Version(s) released in: |
20.11.00
|
Circulation function: | |||
Bug Depends on: | 22844 | ||
Bug Blocks: | |||
Attachments: |
Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal
Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal |
Description
Katrin Fischer
2020-08-22 13:16:33 UTC
Created attachment 109300 [details] [review] Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and enrollmentdate are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now Created attachment 109686 [details] [review] Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and dateexpiry fields are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now Signed-off-by: David Nind <david@davidnind.com> Note: I changed the test plan in the commit message so that it says "dateenrolled and dateexpiry fields" instead of "dateenrolled and enrollmentdate" - it took me a while to figure out why I couldn't find "enrollmentdate". 8-) (In reply to David Nind from comment #3) > Note: I changed the test plan in the commit message so that it says > "dateenrolled and dateexpiry fields" instead of "dateenrolled and > enrollmentdate" - it took me a while to figure out why I couldn't find > "enrollmentdate". 8-) Oops, thx! Created attachment 109891 [details] [review] Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and dateexpiry fields are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |