| Summary: | Move translatable strings out of z3950_search.inc into z3950_search.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, f.demians, jonathan.druart, lucas, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 21156 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js
Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js Bug 26291: (follow-up) Correct stray MSG instances |
||
|
Description
Owen Leonard
2020-08-24 18:24:44 UTC
Created attachment 109032 [details] [review] Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js This patch moves translatable strings out of z3950_search.inc into z3950_search.js, wrapped in the double-underscore function for translation. To test, apply the patch and go to Cataloging. - Click "New from Z39.50/SRU" - In the search form, uncheck all search targets and submit the form. You should get an error: "Please choose at least one external target" - Peform a search which will return multiple pages of results. - Test that you can enter a number in the "Go to page" form to navigate to a specific page. - Enter a non-number in the field and submit. You should get an error, "The page entered is not a number." - Enter a number in the field which is greater than the number of pages of results. Submitting the form should trigger an error, "The page should be a number between 1 and 10." - Perform the same tests from the other Z39.50 search results interfaces: - Acquisitions -> Add to basket -> From an external source. - Authorities -> New authority -> New from Z39.50/SRU. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/z3950_search.js for translation, e.g.: msgid "The page entered is not a number." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Created attachment 110811 [details] [review] Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js This patch moves translatable strings out of z3950_search.inc into z3950_search.js, wrapped in the double-underscore function for translation. To test, apply the patch and go to Cataloging. - Click "New from Z39.50/SRU" - In the search form, uncheck all search targets and submit the form. You should get an error: "Please choose at least one external target" - Peform a search which will return multiple pages of results. - Test that you can enter a number in the "Go to page" form to navigate to a specific page. - Enter a non-number in the field and submit. You should get an error, "The page entered is not a number." - Enter a number in the field which is greater than the number of pages of results. Submitting the form should trigger an error, "The page should be a number between 1 and 10." - Perform the same tests from the other Z39.50 search results interfaces: - Acquisitions -> Add to basket -> From an external source. - Authorities -> New authority -> New from Z39.50/SRU. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/z3950_search.js for translation, e.g.: msgid "The page entered is not a number." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Created attachment 110828 [details] [review] Bug 26291: Move translatable strings out of z3950_search.inc into z3950_search.js This patch moves translatable strings out of z3950_search.inc into z3950_search.js, wrapped in the double-underscore function for translation. To test, apply the patch and go to Cataloging. - Click "New from Z39.50/SRU" - In the search form, uncheck all search targets and submit the form. You should get an error: "Please choose at least one external target" - Peform a search which will return multiple pages of results. - Test that you can enter a number in the "Go to page" form to navigate to a specific page. - Enter a non-number in the field and submit. You should get an error, "The page entered is not a number." - Enter a number in the field which is greater than the number of pages of results. Submitting the form should trigger an error, "The page should be a number between 1 and 10." - Perform the same tests from the other Z39.50 search results interfaces: - Acquisitions -> Add to basket -> From an external source. - Authorities -> New authority -> New from Z39.50/SRU. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/z3950_search.js for translation, e.g.: msgid "The page entered is not a number." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> % git grep MSG_LOADING returns only 2 occurrences in js/z3950_search.js Created attachment 110904 [details] [review] Bug 26291: (follow-up) Correct stray MSG instances Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.05 enhancement, not backported to 19.11.x |