|
Description
David Cook
2020-08-26 04:05:09 UTC
Created attachment 109136 [details] [review] Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Created attachment 109183 [details] [review] Bug 26299: Use same SMS number help text in OPAC as staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Checked and working perfectly. Created attachment 109191 [details] [review] Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nick, are you ok with this? (In reply to Jonathan Druart from comment #4) > Nick, are you ok with this? Alternatively, we could provide a printf pattern for rendering the numbers in a more localized way I suppose? Seems like Template::Toolkit has a few options on that front. Since the OPAC is public-facing, I could see wanting to make it seem more polished than the Staff Interface... (In reply to Jonathan Druart from comment #4) > Nick, are you ok with this? I checked with our educators - their concern is that it not start with 1, which is the indicator of 'long distance' calls here. 9785550123 would be better as it won't end up being a real phone number https://en.wikipedia.org/wiki/555_(telephone_number) (In reply to Nick Clemens from comment #6) > (In reply to Jonathan Druart from comment #4) > > Nick, are you ok with this? > > I checked with our educators - their concern is that it not start with 1, > which is the indicator of 'long distance' calls here. > > 9785550123 would be better as it won't end up being a real phone number > https://en.wikipedia.org/wiki/555_(telephone_number) That's an interesting point. Maybe we should just change the wording (in both interfaces) to something like... "Please enter numbers only. Prefix the number with + if including the country code." After that, the Javascript validation messages should provide enough formatting information? I mention the + in part because I don't think we actually mention that anywhere. (In reply to David Cook from comment #7) > (In reply to Nick Clemens from comment #6) > > (In reply to Jonathan Druart from comment #4) > > > Nick, are you ok with this? > > > > I checked with our educators - their concern is that it not start with 1, > > which is the indicator of 'long distance' calls here. > > > > 9785550123 would be better as it won't end up being a real phone number > > https://en.wikipedia.org/wiki/555_(telephone_number) > > That's an interesting point. > > Maybe we should just change the wording (in both interfaces) to something > like... > > "Please enter numbers only. Prefix the number with + if including the > country code." > > After that, the Javascript validation messages should provide enough > formatting information? I think this is the best solution. Created attachment 109625 [details] [review] Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Created attachment 109667 [details] [review] Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> Created attachment 109991 [details] [review] Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |