Summary: | Self-checkout blocks renew for overdues even when OverduesBlockRenewing allows it in opac-user.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Self checkout | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | lucas, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18349 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 26301: Use CanBookBeRenewed when renewing via self-checkout
Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Bug 26301: Use CanBookBeRenewed when renewing via self-checkout |
Description
David Cook
2020-08-26 05:45:47 UTC
But "./opac/sco/sco-main.pl" is shockingly bad. It's running "CanBookBeIssued" instead of "CanBookBeRenewed" which means all the wrong rules are being applied for a renewal... Created attachment 109137 [details] [review] Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Currently, if you have OverduesBlockCirc set to "Ask for confirmation" and OverduesBlockRenewing set to "allow renewing", you get caught in a loop where you can never renew an overdue material. This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued, which means the correct rules are applied to the correct scenario. To test: a. Set OverduesBlockCirc to "Ask for confirmation" b. Ensure "OverduesBlockRenewing" set to "allow renewing" 0. Apply the patch 1. Checkin item barcode 3999900000001 2. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3. Checkout item barcode 3999900000001 to 1 year ago 4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5. Login as the "koha" user 6. Click on "Renew item" 7. Note that the item is renewed 8. Checkin item barcode 3999900000001 9. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 10. Checkout item barcode 3999900000001 to 1 year ago 11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 12. Login as the "koha" user 13. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 14. Click "Submit" 15. Note the system says the item is already checked out and it prompts you to click "Renew item" in this screen 16. Click "Renew item" 17. Note the system says "Item renewed" near the top of the screen, and the "Due" date near the bottom of the screen is more recent than the original due date 18. Checkin item barcode 3999900000001 19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 20. Login as the "koha" user 21. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 22. Click "Submit" 23. Note the system says "Item checked out" and the item appears in the checkouts at the bottom of the screen Created attachment 109791 [details] [review] Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Currently, if you have OverduesBlockCirc set to "Ask for confirmation" and OverduesBlockRenewing set to "allow renewing", you get caught in a loop where you can never renew an overdue material. This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued, which means the correct rules are applied to the correct scenario. To test: a. Set OverduesBlockCirc to "Ask for confirmation" b. Ensure "OverduesBlockRenewing" set to "allow renewing" 0. Apply the patch 1. Checkin item barcode 3999900000001 2. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3. Checkout item barcode 3999900000001 to 1 year ago 4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5. Login as the "koha" user 6. Click on "Renew item" 7. Note that the item is renewed 8. Checkin item barcode 3999900000001 9. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 10. Checkout item barcode 3999900000001 to 1 year ago 11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 12. Login as the "koha" user 13. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 14. Click "Submit" 15. Note the system says the item is already checked out and it prompts you to click "Renew item" in this screen 16. Click "Renew item" 17. Note the system says "Item renewed" near the top of the screen, and the "Due" date near the bottom of the screen is more recent than the original due date 18. Checkin item barcode 3999900000001 19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 20. Login as the "koha" user 21. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 22. Click "Submit" 23. Note the system says "Item checked out" and the item appears in the checkouts at the bottom of the screen Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, fix works as expected.. Signing off (In reply to Martin Renvoize from comment #4) > Good catch, fix works as expected.. Signing off Thanks, Martin. The credit goes to one of my very diligent librarians! Created attachment 109941 [details] [review] Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Currently, if you have OverduesBlockCirc set to "Ask for confirmation" and OverduesBlockRenewing set to "allow renewing", you get caught in a loop where you can never renew an overdue material. This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued, which means the correct rules are applied to the correct scenario. To test: a. Set OverduesBlockCirc to "Ask for confirmation" b. Ensure "OverduesBlockRenewing" set to "allow renewing" 0. Apply the patch 1. Checkin item barcode 3999900000001 2. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3. Checkout item barcode 3999900000001 to 1 year ago 4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5. Login as the "koha" user 6. Click on "Renew item" 7. Note that the item is renewed 8. Checkin item barcode 3999900000001 9. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 10. Checkout item barcode 3999900000001 to 1 year ago 11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 12. Login as the "koha" user 13. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 14. Click "Submit" 15. Note the system says the item is already checked out and it prompts you to click "Renew item" in this screen 16. Click "Renew item" 17. Note the system says "Item renewed" near the top of the screen, and the "Due" date near the bottom of the screen is more recent than the original due date 18. Checkin item barcode 3999900000001 19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 20. Login as the "koha" user 21. Type "3999900000001" into the box under "Scan a new item or enter its barcode" 22. Click "Submit" 23. Note the system says "Item checked out" and the item appears in the checkouts at the bottom of the screen Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 20.11, thanks to everybody involved! doesn't apply clean to 20.05.x, if needed please rebase |