Summary: | Elasticsearch cxn_pool must be configurable (again) | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Searching - Elasticsearch | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | aleisha, fridolin.somers, jonathan.druart, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04
|
|
Circulation function: | |||
Bug Depends on: | 21974, 24823 | ||
Bug Blocks: | |||
Attachments: |
Bug 26309: Unit tests
Bug 26309: Make cxn_pool configurable Bug 26309: Unit tests Bug 26309: Make cxn_pool configurable Bug 26309: Unit tests Bug 26309: Make cxn_pool configurable |
Description
Nick Clemens (kidclamp)
2020-08-27 15:02:49 UTC
Created attachment 109237 [details] [review] Bug 26309: Unit tests Created attachment 109238 [details] [review] Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds Bug 25273 moved t/Koha/SearchEngine/Elasticsearch.t to t/db_dependent/Koha/SearchEngine/Elasticsearch.t but patch still applies ;) Created attachment 109578 [details] [review] Bug 26309: Unit tests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 109579 [details] [review] Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 109589 [details] [review] Bug 26309: Unit tests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 109590 [details] [review] Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, tests pass and QA script passes. Passing QA. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 missing dependencies, not backported to 19.11.x |