Bug 26325

Summary: Add primary_key_exists function to Installer.pm
Product: Koha Reporter: Nick Clemens <nick>
Component: Architecture, internals, and plumbingAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: lucas
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00
Bug Depends on:    
Bug Blocks: 26326    
Attachments: Bug 26325: Add primary_key_exists check to C4::Installer
Bug 26325: Add primary_key_exists check to C4::Installer
Bug 26325: Add primary_key_exists check to C4::Installer

Description Nick Clemens 2020-08-31 16:43:34 UTC
Some tables don't have a primary key - for atomic update purposes it would be nice to be able to test this
Comment 1 Nick Clemens 2020-08-31 16:44:59 UTC
Created attachment 109372 [details] [review]
Bug 26325: Add primary_key_exists check to C4::Installer

To test:
1 - prove -v t/db_dependent/Installer.t
Comment 2 Brandon J 2020-09-15 15:57:45 UTC
Created attachment 110114 [details] [review]
Bug 26325: Add primary_key_exists check to C4::Installer

To test:
1 - prove -v t/db_dependent/Installer.t

Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
Comment 3 Katrin Fischer 2020-09-15 20:09:09 UTC
Created attachment 110124 [details] [review]
Bug 26325: Add primary_key_exists check to C4::Installer

To test:
1 - prove -v t/db_dependent/Installer.t

Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-10-01 09:45:25 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-10-20 17:35:21 UTC
enhancement will not be backported to 20.05.x