Summary: | Koha::Account::pay incorrectly defaults to '0' for manager_id | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | joonas.kylmala |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 22008 | ||
Bug Blocks: | 14825 | ||
Attachments: | Bug 26332: Remove hard coded '0' for manager_id |
Description
Martin Renvoize (ashimema)
2020-09-01 08:17:35 UTC
Hmm.. The data in question is coming from the userenv.. so in theory should always be set and not require a fallback at all. I think this perhaps highlights an issue in some plugin code not setting userenv properly in my case.. but I still feel we should not be defaulting back to '0' and exploding.. Created attachment 109430 [details] [review] Bug 26332: Remove hard coded '0' for manager_id This patch removes the fallback to '0' for the manager_id in Koha::Account::pay. This will only affect plugins that contain a background callback that doesn't set the user environment. *** This bug has been marked as a duplicate of bug 25606 *** |