| Summary: | Remove unused authorities script should skip merge | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Command-line Utilities | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, david, ephetteplace, josef.moravec, m.de.rooy, robin, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.07
|
|
| Circulation function: | |||
| Attachments: |
Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities
Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities |
||
|
Description
Nick Clemens (kidclamp)
2020-09-01 13:29:21 UTC
Created attachment 109431 [details] [review] Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities This script checks that an authority is not being used before deleting it. We do not need to check biblios for the authority id as we have already verified it is unused. TO test: 1 - Reset db to koha test database 2 - perl misc/migration_tools/remove_unused_authorities.pl -t 3 - Note a number of unsued authorities 4 - perl misc/migration_tools/remove_unused_authorities.pl -c 5 - Note authorities are removed 6 - Reset db 7 - Apply patch 8 - perl misc/migration_tools/remove_unused_authorities.pl -t 9 - Note results are the same 10 - perl misc/migration_tools/remove_unused_authorities.pl -c 11 - Note results are the same Created attachment 113030 [details] [review] Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities This script checks that an authority is not being used before deleting it. We do not need to check biblios for the authority id as we have already verified it is unused. TO test: 1 - Reset db to koha test database 2 - perl misc/migration_tools/remove_unused_authorities.pl -t 3 - Note a number of unsued authorities 4 - perl misc/migration_tools/remove_unused_authorities.pl -c 5 - Note authorities are removed 6 - Reset db 7 - Apply patch 8 - perl misc/migration_tools/remove_unused_authorities.pl -t 9 - Note results are the same 10 - perl misc/migration_tools/remove_unused_authorities.pl -c 11 - Note results are the same Signed-off-by: David Nind <david@davidnind.com> Results from running through the test plan. Before patch applied ==================== perl misc/migration_tools/remove_unused_authorities.pl -t 1706 authorities parsed 493 can be deleted because unused 1213 unchanged because used perl misc/migration_tools/remove_unused_authorities.pl -c 1706 authorities parsed 493 deleted because unused 1213 unchanged because used After patch applied =================== perl misc/migration_tools/remove_unused_authorities.pl -t 1706 authorities parsed 493 can be deleted because unused 1213 unchanged because used perl misc/migration_tools/remove_unused_authorities.pl -c 1706 authorities parsed 493 deleted because unused 1213 unchanged because used Created attachment 113745 [details] [review] Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities This script checks that an authority is not being used before deleting it. We do not need to check biblios for the authority id as we have already verified it is unused. TO test: 1 - Reset db to koha test database 2 - perl misc/migration_tools/remove_unused_authorities.pl -t 3 - Note a number of unsued authorities 4 - perl misc/migration_tools/remove_unused_authorities.pl -c 5 - Note authorities are removed 6 - Reset db 7 - Apply patch 8 - perl misc/migration_tools/remove_unused_authorities.pl -t 9 - Note results are the same 10 - perl misc/migration_tools/remove_unused_authorities.pl -c 11 - Note results are the same Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 20.11, thanks to everybody involved! Pushed to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |