Bug 26338

Created attachment 109432 [details]
Screenshot

(In reply to Fridolin SOMERS from comment #1)
> Created attachment 109432 [details]
> Screenshot

With the example of plugin Carrousel https://inlibro.com/instructions-carrousel/

Created attachment 109433 [details] [review]
Bug 26338: Show tool plugins run in tools home

In tools home there is a link to the table showing tool plugins.
Would be great to be able to run a tool plugin directly from tools home.

Also adds the behavior than if there is no tool plugin, "Tool plugins"
section is not displayed in tools home.
No need of a link that goes to an empty table ;)

Test plan :
1) Enable plugins, dont install any
2) Go to "Tools" module : /cgi-bin/koha/tools/tools-home.pl
3) Check you dont see "Tool plugins"
4) Install a tool plugin like Carrousel https://inlibro.com/instructions-carrousel/
5) Refresh /cgi-bin/koha/tools/tools-home.pl
6) Check you see "Tool plugins" and a link to Carrousel
7) Click on link to Carrousel => You see plugin run
8) Disable Carrousel plugin
9) Refresh /cgi-bin/koha/tools/tools-home.pl
10) Check you dont see "Tool plugins"

I think I'd remove the "run plugin" bit. And maybe make it a list.

(In reply to Fridolin SOMERS from comment #0)
> In tools home there is a link to the table showing tool plugins.
> Would be great to be able to run a tool plugin directly from tools home.

I've been having the same idea! I think this would be useful from a UX perspective.

Created attachment 109835 [details] [review]
Bug 26338: Show tool plugins run in tools home

In tools home there is a link to the table showing tool plugins.
Would be great to be able to run a tool plugin directly from tools home.

Also adds the behavior than if there is no tool plugin, "Tool plugins"
section is not displayed in tools home.
No need of a link that goes to an empty table ;)

Test plan :
1) Enable plugins, dont install any
2) Go to "Tools" module : /cgi-bin/koha/tools/tools-home.pl
3) Check you dont see "Tool plugins"
4) Install a tool plugin like Carrousel https://inlibro.com/instructions-carrousel/
5) Refresh /cgi-bin/koha/tools/tools-home.pl
6) Check you see "Tool plugins" and a link to Carrousel
7) Click on link to Carrousel => You see plugin run
8) Disable Carrousel plugin
9) Refresh /cgi-bin/koha/tools/tools-home.pl
10) Check you dont see "Tool plugins"

(In reply to Katrin Fischer from comment #4)
> I think I'd remove the "run plugin" bit. And maybe make it a list.

Nicer indeed.
I've changed to ul li.
This needs a change in CSS to replace text-indent with padding-left.

Created attachment 109836 [details]
Screenshot

Nice! too bad I can't signoff that one! (same organisation).
If nobody has signed within a month I will ;)
Good job frido!

Created attachment 109842 [details] [review]
Bug 26338: Show tool plugins run in tools home

In tools home there is a link to the table showing tool plugins.
Would be great to be able to run a tool plugin directly from tools home.

Also adds the behavior than if there is no tool plugin, "Tool plugins"
section is not displayed in tools home.
No need of a link that goes to an empty table ;)

Test plan :
1) Enable plugins, dont install any
2) Go to "Tools" module : /cgi-bin/koha/tools/tools-home.pl
3) Check you dont see "Tool plugins"
4) Install a tool plugin like Carrousel https://inlibro.com/instructions-carrousel/
5) Refresh /cgi-bin/koha/tools/tools-home.pl
6) Check you see "Tool plugins" and a link to Carrousel
7) Click on link to Carrousel => You see plugin run
8) Disable Carrousel plugin
9) Refresh /cgi-bin/koha/tools/tools-home.pl
10) Check you dont see "Tool plugins"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Created attachment 109993 [details] [review]
Bug 26338: Show tool plugins run in tools home

In tools home there is a link to the table showing tool plugins.
Would be great to be able to run a tool plugin directly from tools home.

Also adds the behavior than if there is no tool plugin, "Tool plugins"
section is not displayed in tools home.
No need of a link that goes to an empty table ;)

Test plan :
1) Enable plugins, dont install any
2) Go to "Tools" module : /cgi-bin/koha/tools/tools-home.pl
3) Check you dont see "Tool plugins"
4) Install a tool plugin like Carrousel https://inlibro.com/instructions-carrousel/
5) Refresh /cgi-bin/koha/tools/tools-home.pl
6) Check you see "Tool plugins" and a link to Carrousel
7) Click on link to Carrousel => You see plugin run
8) Disable Carrousel plugin
9) Refresh /cgi-bin/koha/tools/tools-home.pl
10) Check you dont see "Tool plugins"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Pushed to master for 20.11, thanks to everybody involved!

enhancement will not be backported to 20.05.x

Hi all, the Tools > Tool plugins link no longer shows if no plugins are installed, but don't we need to get to that page in order to upload a plugin?

Are we missing something?

Hi, Owen has let me know you can do it in the Koha administration module but when you click on the link, in the breadcrumbs it says it's in the Tools module.

(In reply to wainuiwitikapark from comment #15)
> Hi, Owen has let me know you can do it in the Koha administration module but
> when you click on the link, in the breadcrumbs it says it's in the Tools
> module.

Ah indeed. Please create a new bug to fix the breadcrumbs.

In my opinion installing plugins is an administration action.