Bug 26342

Summary: Suspended hold not marked filled when patron checks out item
Product: Koha Reporter: Andrew Fuerste-Henry <andrewfh>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: In Discussion --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: cbrannon, gmcharlt, jrobb, kyle.m.hall, mspinney, rcoert, sbcornell
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Andrew Fuerste-Henry 2020-09-01 15:07:44 UTC
To recreate:
- place an item-level hold
- suspend the hold
- without unsuspending or capturing the hold, check the item out to the patron
- the suspended hold remains on the patron account

If a hold is not suspended (and not captured) and the patron checks the item out, the hold is marked as filled. Should we do the same on suspended holds?
Comment 1 Katrin Fischer 2023-12-10 08:36:28 UTC
On first glance I think the behavior is correct. When the hold is suspended, it's not in effect, so it should not be triggered/filled.
I think at the circulation desk, we could ask, but then the issue remains for SIP2/self checkout.
Comment 2 Jason Robb 2024-01-23 16:28:13 UTC
This has caused some confusion with my libraries. It usually happens when the patron suspends a hold until a certain date, finds the item on the shelf and checks it out, the hold unsuspends in the meantime and when they return the item, it tries to give it to them again. That can lead to an upset patron if they get notified to come back in to pick up a hold without realizing it is the item they recently returned.

A clever patron could also abuse this to keep an item longer by placing a hold, suspending it, checking the item out, then unsuspending right before they return it. That would keep their hold at the top of the list so when they return the item, they'd skip over any other holds and get the item again.

I can't think of a case where we would want to maintain a suspended hold if the item is checked out to the requesting patron but we're in a largely public library setting. Maybe "fill suspended holds on checkout" could be a system preference?
Comment 3 Christopher Brannon 2024-01-25 19:30:26 UTC
I think that if the item being checked out is a suspended hold, it should prompt staff to ask if the patron wants to retain this hold or cancel it.

I think the self-check should ask as well.  Can this be accomplished through SIP, or should it just cancel it and send the patron a notification with an explanation, or ignore it all together (maybe a setting to decide what the preference is)?
Comment 4 Sarah Cornell 2024-03-25 20:32:20 UTC
I agree with Christopher.  Koha should prompt staff to ask if the patron would like to cancel the suspended hold, and it should prompt the patron at the self check as well.