Summary: | Overdue report shows incorrect branches for patron, holdingbranch, and homebranch | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Circulation | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, emmi.takkinen, gmcharlt, kyle.m.hall, lucas, martin.renvoize, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04, 19.11.10
|
|
Circulation function: | |||
Bug Depends on: | 21852 | ||
Bug Blocks: | |||
Attachments: |
Bug 26362: Show correct libraries in overdues report
Bug 26362: Show correct libraries in overdues report Bug 26362: Show correct libraries in overdues report |
Description
David Cook
2020-09-03 04:51:19 UTC
Created attachment 109569 [details] [review] Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Created attachment 109570 [details] [review] Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Created attachment 109598 [details] [review] Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I'm amazed this hasn't been picked up before! Trivial patch, works as expected. Passing QA Pushed to master for 20.11, thanks to everybody involved! (In reply to Martin Renvoize from comment #4) > I'm amazed this hasn't been picked up before! I know, right?! It's been a bug for 2 years. I wonder how frequently people use that report or how carefully they read it or how much inter-branch checkouts happen... Thanks everyone for the quickness! backported to 20.05.x for 20.05.04 backported to 19.11.x for 19.11.10 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |