| Summary: | Update for 19974 is not idempotent | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, martin.renvoize, victor, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,20.11.12,20.05.18
|
|
| Circulation function: | |||
| Bug Depends on: | 19974 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 26374: update from bug 19974 is not idempotent
Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items Bug 26374: update from bug 19974 is not idempotent Bug 26374: update from bug 19974 is not idempotent |
||
|
Description
Nick Clemens (kidclamp)
2020-09-03 16:35:37 UTC
Created attachment 109633 [details] [review] Bug 26374: update from bug 19974 is not idempotent Created attachment 109664 [details] [review] Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items Additionally, only include renewable items in 'Renew all' To test: 1 - Check out some items to a patron, ideally: Some not renewable because set for auto renewal Some not renewable because of holds Some renewable 2 - Confirm 'Renew selected' and 'Renew all' show on the opac 3 - Click 'Renew all' 4 - You get errors about the non-renewable items? 5 - Check in all renewable items 6 - Confirm you still see renew buttons 7 - Apply patch 8 - Refresh and you shoudl not see renew buttons 9 - Check out a renewable item 10 - Click 'Renew all' 11 - Renewable item is renewed with no error 12 - Try again with 'Renew selected' 13 - Confirm it works as expected Created attachment 109681 [details] [review] Bug 26374: update from bug 19974 is not idempotent Does this depend on Bug 19974? Can you please provide a test plan? (In reply to Aleisha Amohia from comment #4) > Does this depend on Bug 19974? Can you please provide a test plan? It does depend on 19974 Essentially run the update statement, set some values, run it again, they are deleted. I believe this was noticed because of internal backports, filing here because it could happen to others Created attachment 127027 [details] [review] Bug 26374: update from bug 19974 is not idempotent Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Clear and understandable fix.. tested. Going straight for QA Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.12 Backported: Pushed to 20.05.x branch for 20.05.18 Not backporting to 19.11.x - LTS version will just backport security patches |