| Summary: | opac.scss calls non-existent image | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alvaro Cornejo <cornejo.alvaro> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | andrew, david, jonathan.druart, victor |
| Version: | 20.05 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This patch removes some obsolete CSS from the OPAC which calls a non-existent image.
|
Version(s) released in: |
20.05.08
|
| Circulation function: | |||
| Attachments: |
Bug 26397: opac.scss calls non-existent image
Bug 26397: [20.05.x] opac.scss calls non-existent image Bug 26397: [20.05.x] opac.scss calls non-existent image Bug 26397: [20.05.x] opac.scss calls non-existent image |
||
|
Description
Alvaro Cornejo
2020-09-06 01:12:40 UTC
Valid in 20.05.x Owen, could you have a look? It's coming from bug 10309, but it has never been copied from ccsr. Created attachment 114101 [details] [review] Bug 26397: opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Patch no longer applies 8-( Applying: Bug 26397: opac.scss calls non-existent image Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss A koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss deleted in HEAD and modified in Bug 26397: opac.scss calls non-existent image. Version Bug 26397: opac.scss calls non-existent image of koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss left in tree. Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Created attachment 114304 [details] [review] Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. (In reply to David Nind from comment #4) > Patch no longer applies 8-( Sorry I should have made it more clear, so I've modified the commit message: The patch is specifically for 20.05.x Created attachment 114397 [details] [review] Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Signed-off-by: David Nind <david@davidnind.com> Created attachment 114572 [details] [review] Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Sending to 20.05 RM queue. Pushed to 20.05.x for 20.05.08 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |