Summary: | Suggestions filter does not work | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrewfh, fridolin.somers, julian.maurice, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.03
|
|
Bug Depends on: | 27047 | ||
Bug Blocks: | |||
Attachments: |
Bug 26406: Fix suggestions filter at the OPAC
Bug 26406: Fix suggestions filter at the OPAC Bug 26406: Fix suggestions filter at the OPAC Bug 26406: Fix suggestions filter at the OPAC |
Description
Jonathan Druart
2020-09-08 13:21:22 UTC
Created attachment 109748 [details] [review] Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options Created attachment 109762 [details] [review] Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options Signed-off-by: David Nind <david@davidnind.com> Created attachment 116630 [details] [review] Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options Signed-off-by: David Nind <david@davidnind.com> I completely forgot about this patch and, meanwhile, I wrote bug 27047. Do we still need this patch? The search box on the opac suggestions page seems to work now ? Changing status to reflect need for feedback. Yes, I think it is. You can filter server-side, better than the DT global filter IMO. Created attachment 116862 [details] [review] Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Missing dependency from bug 27047, which needs a rebase. Please rebase that for backport if this is needed. |