| Summary: | Use split button to offer choice of WYSIWYG or code editor for news | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Tools | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, dcook, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 22660 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news
Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news Bug 26431: Update NewsToolEditor system preference description Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news Bug 26431: Update NewsToolEditor system preference description |
||
|
Description
Owen Leonard
2020-09-10 19:05:49 UTC
Created attachment 109865 [details] [review] Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news This patch modifies the news interface so that the user is offered a choice of editing news items using the default editor as defined by the NewsToolEditor system preference or the non-default one. To test, apply the patch and go to Tools -> News. - In the list of news items you should see an "Edit" split button in each row. - Clicking the "Edit" part of the button should open the edit view with the correct editor as defined by the NewsToolEditor preference. - Clicking the menu arrow on the button should offer the other editing method: - If NewsToolEditor is set to "WYSIWYG," the menu should offer "text editor." - If NewsToolEditor is set to "text editor," the menu should offer "WYSIWYG editor." - Test the button with the NewsToolEditor preference set to both options and confirm that the button and menu work correctly. Sounds like a great idea! Will try to come back to this one... Created attachment 109950 [details] [review] Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news This patch modifies the news interface so that the user is offered a choice of editing news items using the default editor as defined by the NewsToolEditor system preference or the non-default one. To test, apply the patch and go to Tools -> News. - In the list of news items you should see an "Edit" split button in each row. - Clicking the "Edit" part of the button should open the edit view with the correct editor as defined by the NewsToolEditor preference. - Clicking the menu arrow on the button should offer the other editing method: - If NewsToolEditor is set to "WYSIWYG," the menu should offer "text editor." - If NewsToolEditor is set to "text editor," the menu should offer "WYSIWYG editor." - Test the button with the NewsToolEditor preference set to both options and confirm that the button and menu work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 109980 [details] [review] Bug 26431: Update NewsToolEditor system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 109981 [details] [review] Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news This patch modifies the news interface so that the user is offered a choice of editing news items using the default editor as defined by the NewsToolEditor system preference or the non-default one. To test, apply the patch and go to Tools -> News. - In the list of news items you should see an "Edit" split button in each row. - Clicking the "Edit" part of the button should open the edit view with the correct editor as defined by the NewsToolEditor preference. - Clicking the menu arrow on the button should offer the other editing method: - If NewsToolEditor is set to "WYSIWYG," the menu should offer "text editor." - If NewsToolEditor is set to "text editor," the menu should offer "WYSIWYG editor." - Test the button with the NewsToolEditor preference set to both options and confirm that the button and menu work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 109982 [details] [review] Bug 26431: Update NewsToolEditor system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Love this! Only one thing: I wondered if WYSIWYG is a term that is well known. Maybe we should make the choice HTML editor vs. Visual editor or similar? (In reply to Katrin Fischer from comment #7) > Love this! > > Only one thing: I wondered if WYSIWYG is a term that is well known. Maybe we > should make the choice HTML editor vs. Visual editor or similar? Mmm that's a really good point. While I know that I've used WYSIWYG in Koha in the past, I think it is an outdated term these days. I notice references to "rich-text editor" but I don't think people would get that either. So maybe "Visual editor"? Pushed to master for 20.11, thanks to everybody involved! If you work with the HTML system preferences, which have moved to the News, this is very very handy. Choosing to backport to 20.05.x for 20.05.05 enhancement, not backported to 19.11.x |