Summary: | koha-elasticsearch --commit parameter is not used | ||
---|---|---|---|
Product: | Koha | Reporter: | Joonas Kylmälä <joonas.kylmala> |
Component: | Command-line Utilities | Assignee: | Joonas Kylmälä <joonas.kylmala> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas, nick, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.05
|
|
Circulation function: | |||
Attachments: |
Bug 26448: Don't overwrite commit parameter passed to koha-elasticsearch
Bug 26448: Don't overwrite commit parameter passed to koha-elasticsearch |
Description
Joonas Kylmälä
2020-09-14 07:24:01 UTC
Created attachment 110032 [details] [review] Bug 26448: Don't overwrite commit parameter passed to koha-elasticsearch The "--commit" or "-c" parameter was incorrectly not used if it was passed to the koha-elasticsearch program. To test: 1) Before patch notice koha-elasticsearch --rebuild --commit 1 -v <instance> only commits every 5000 records 2) Apply patch and notice the above command commits every 1 record Created attachment 110037 [details] [review] Bug 26448: Don't overwrite commit parameter passed to koha-elasticsearch The "--commit" or "-c" parameter was incorrectly not used if it was passed to the koha-elasticsearch program. To test: 1) Before patch notice koha-elasticsearch --rebuild --commit 1 -v <instance> only commits every 5000 records 2) Apply patch and notice the above command commits every 1 record Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice catch, obvious fix, moving to PQA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.05 |