Summary: | Column configuration for account-fines hides the wrong columns | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 24690: Fix column configuration for fines trasactions
Bug 24690: Fix column configuration for fines trasactions Bug 26490: Fix column configuration for fines trasactions |
Description
Caroline Cyr La Rose
2020-09-18 15:05:47 UTC
Created attachment 110440 [details] [review] Bug 24690: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option Created attachment 110546 [details] [review] Bug 24690: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option https://bugs.koha-community.org/show_bug.cgi?id=26490 Signed-off-by: David Nind <david@davidnind.com> Created attachment 110742 [details] [review] Bug 26490: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Ooops; Works as expected, thanks for the fix Katrin. Passing QA Pushed to master for 20.11, thanks to everybody involved! doesnt apply cleanly to 20.05.x, no backport |