Summary: | "Hide all columns" throws Javascript error on aqplan.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, bolshawh, lucas, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.05, 19.11.12
|
|
Circulation function: | |||
Attachments: |
Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl
Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl |
Description
David Cook
2020-09-21 03:03:59 UTC
Created attachment 110449 [details] [review] Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl This patch updates the JavaScript for checking and unchecking checkboxes on the Acquisitions planning page so that it doesn't require the checkboxes plugin. To test, apply the patch and go to Administration -> Budgets -> Budget details -> Planning. On the planning page, test the "Show all columns" and "Hide all columns" checkboxes. They should work correctly to show and hide the correct columns. Created attachment 110465 [details] [review] Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl This patch updates the JavaScript for checking and unchecking checkboxes on the Acquisitions planning page so that it doesn't require the checkboxes plugin. To test, apply the patch and go to Administration -> Budgets -> Budget details -> Planning. On the planning page, test the "Show all columns" and "Hide all columns" checkboxes. They should work correctly to show and hide the correct columns. Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Tested on sandbox and the "Show all columns" and "Hide all columns" checkboxes now work correctly and the javascript error has disappeared. Created attachment 110487 [details] [review] Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl This patch updates the JavaScript for checking and unchecking checkboxes on the Acquisitions planning page so that it doesn't require the checkboxes plugin. To test, apply the patch and go to Administration -> Budgets -> Budget details -> Planning. On the planning page, test the "Show all columns" and "Hide all columns" checkboxes. They should work correctly to show and hide the correct columns. Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.05 backported to 19.11.x for 19.11.12 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |