| Summary: | Article requests: Add datatables to requests form in staff client | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Circulation | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, lucas, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 26501: Add datatables to article-requests form
Bug 26501: Add datatables to article-requests form Bug 26501: Add datatables to article-requests form Bug 26501: Add datatables to article-requests form |
||
|
Description
Marcel de Rooy
2020-09-21 13:01:07 UTC
Created attachment 110470 [details] [review] Bug 26501: Add datatables to article-requests form Actually two tables: one for pending and processing. Variable active_table has been renamed to active_tab. To prevent a flickering form we hide stuff until ready. Test plan: [1] Submit a few article requests. [2] Verify that Process, Complete and Cancel still work via Actions. [3] Test again with multiselect and top Actions menu. [4] Test Search and Sort on the datatable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> In my test the "Complete request" menu item trips a JavaScript error under both the "Pending" and "Processing" tabs: "Uncaught ReferenceError: active_table is not defined" (In reply to Owen Leonard from comment #2) > In my test the "Complete request" menu item trips a JavaScript error under > both the "Pending" and "Processing" tabs: "Uncaught ReferenceError: > active_table is not defined" Have tested quite a bit but also with different versions. So i will retest right away. Thanks. Created attachment 110532 [details] [review] Bug 26501: Add datatables to article-requests form Actually two tables: one for pending and processing. Variable active_table has been renamed to active_tab. To prevent a flickering form we hide stuff until ready. Test plan: [1] Submit a few article requests. [2] Verify that Process, Complete and Cancel still work via Actions. [3] Test again with multiselect and top Actions menu. [4] Test Search and Sort on the datatable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> - active_table.row( a.closest('tr') ).remove().draw();
+ active_datatable.row( a.closest('tr') ).remove().draw();
Typo.
I used Process and Cancel to test. Probably skipped Complete completely ;)
Created attachment 110600 [details] [review] Bug 26501: Add datatables to article-requests form Actually two tables: one for pending and processing. Variable active_table has been renamed to active_tab. To prevent a flickering form we hide stuff until ready. Test plan: [1] Submit a few article requests. [2] Verify that Process, Complete and Cancel still work via Actions. [3] Test again with multiselect and top Actions menu. [4] Test Search and Sort on the datatable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Owen Leonard from comment #6) > Signed-off-by: Owen Leonard <oleonard@myacpl.org> Great! Created attachment 110613 [details] [review] Bug 26501: Add datatables to article-requests form Actually two tables: one for pending and processing. Variable active_table has been renamed to active_tab. To prevent a flickering form we hide stuff until ready. Test plan: [1] Submit a few article requests. [2] Verify that Process, Complete and Cancel still work via Actions. [3] Test again with multiselect and top Actions menu. [4] Test Search and Sort on the datatable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #8) > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |