| Summary: | Allow to limit on standing orders in acquisition advanced search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 26503: Add limit for standing orders to acq advanced search
Bug 26503: Add unit tests Bug 26503: Add limit for standing orders to acq advanced search Bug 26503: Add unit tests Bug 26503: Add limit for standing orders to acq advanced search Bug 26503: Add unit tests Bug 26503: Add limit for standing orders to acq advanced search Bug 26503: Add unit tests Bug 26503: Add unit tests |
||
|
Description
Katrin Fischer
2020-09-21 14:47:30 UTC
Created attachment 110521 [details] [review] Bug 26503: Add limit for standing orders to acq advanced search This allows to filter on standing orders on the acq advanced search checkbox. For this purpose a new checkbox is shown behind the order status search option. As both not yet ordered and standing orders have the status 'new' or partially received internally, this seems like a good placement as it will help distinguish these cases clearly. new + standing order = standing order, but nothing received yet partially received + standing order = active standing order all status + standing order = all standing orders To test: - Create some baskets with at least one order, some 'standing' and others not - In the top toolbar choose tab Orders search > Advanced search - Make some searches with and without the new 'Standing order' option - Verify the right orders are found - In the search results standing orders will now show with the status + (standing order). Created attachment 110522 [details] [review] Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Created attachment 110549 [details] [review] Bug 26503: Add limit for standing orders to acq advanced search This allows to filter on standing orders on the acq advanced search checkbox. For this purpose a new checkbox is shown behind the order status search option. As both not yet ordered and standing orders have the status 'new' or partially received internally, this seems like a good placement as it will help distinguish these cases clearly. new + standing order = standing order, but nothing received yet partially received + standing order = active standing order all status + standing order = all standing orders To test: - Create some baskets with at least one order, some 'standing' and others not - In the top toolbar choose tab Orders search > Advanced search - Make some searches with and without the new 'Standing order' option - Verify the right orders are found - In the search results standing orders will now show with the status + (standing order). Signed-off-by: David Nind <david@davidnind.com> Created attachment 110550 [details] [review] Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Signed-off-by: David Nind <david@davidnind.com> Can you remove the changes to MARC21slimUtils? Sorry, of course, that one slipped in untintentionally. Created attachment 111431 [details] [review] Bug 26503: Add limit for standing orders to acq advanced search This allows to filter on standing orders on the acq advanced search checkbox. For this purpose a new checkbox is shown behind the order status search option. As both not yet ordered and standing orders have the status 'new' or partially received internally, this seems like a good placement as it will help distinguish these cases clearly. new + standing order = standing order, but nothing received yet partially received + standing order = active standing order all status + standing order = all standing orders To test: - Create some baskets with at least one order, some 'standing' and others not - In the top toolbar choose tab Orders search > Advanced search - Make some searches with and without the new 'Standing order' option - Verify the right orders are found - In the search results standing orders will now show with the status + (standing order). Signed-off-by: David Nind <david@davidnind.com> Created attachment 111432 [details] [review] Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Signed-off-by: David Nind <david@davidnind.com> Created attachment 111433 [details] [review] Bug 26503: Add limit for standing orders to acq advanced search This allows to filter on standing orders on the acq advanced search checkbox. For this purpose a new checkbox is shown behind the order status search option. As both not yet ordered and standing orders have the status 'new' or partially received internally, this seems like a good placement as it will help distinguish these cases clearly. new + standing order = standing order, but nothing received yet partially received + standing order = active standing order all status + standing order = all standing orders To test: - Create some baskets with at least one order, some 'standing' and others not - In the top toolbar choose tab Orders search > Advanced search - Make some searches with and without the new 'Standing order' option - Verify the right orders are found - In the search results standing orders will now show with the status + (standing order). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 111434 [details] [review] Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Added a few baskets and orders (standing and not), filtering on 'is_standing' works as expected. Tests pass. No QA script complaints. Well done, Katrina! Created attachment 111483 [details] [review] Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> JD Amended patch: perltidy Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |