| Summary: | Add Koha::Acquisition::Basket->orders | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26515 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 26524: Unit tests
Bug 26524: Add Koha::Acquisition::Basket->orders Bug 26524: Unit tests Bug 26524: Add Koha::Acquisition::Basket->orders Bug 26524: Unit tests Bug 26524: Add Koha::Acquisition::Basket->orders Bug 26524: Save some processor cycles |
||
|
Description
Tomás Cohen Arazi (tcohen)
2020-09-23 18:55:00 UTC
Created attachment 110616 [details] [review] Bug 26524: Unit tests Created attachment 110617 [details] [review] Bug 26524: Add Koha::Acquisition::Basket->orders This patch adds a handy accessor for a basket's orders. It can be used to embed orders on an API call or be used in controller scripts to replace C4::* methods. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Created attachment 110622 [details] [review] Bug 26524: Unit tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 110623 [details] [review] Bug 26524: Add Koha::Acquisition::Basket->orders This patch adds a handy accessor for a basket's orders. It can be used to embed orders on an API call or be used in controller scripts to replace C4::* methods. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Created attachment 110797 [details] [review] Bug 26524: Unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110798 [details] [review] Bug 26524: Add Koha::Acquisition::Basket->orders This patch adds a handy accessor for a basket's orders. It can be used to embed orders on an API call or be used in controller scripts to replace C4::* methods. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Would love to see some code using this new method. Created attachment 110914 [details] [review] Bug 26524: Save some processor cycles (In reply to Jonathan Druart from comment #8) > Created attachment 110914 [details] [review] [review] > Bug 26524: Save some processor cycles XD Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |