Summary: | Remove issues old_issues redundant indexes | ||
---|---|---|---|
Product: | Koha | Reporter: | Didier Gautheron <didier.gautheron> |
Component: | Database | Assignee: | Didier Gautheron <didier.gautheron> |
Status: | Patch doesn't apply --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Bug 26535: Remove issues tables redundant indexes |
Description
Didier Gautheron
2020-09-25 08:56:44 UTC
Created attachment 110735 [details] [review] Bug 26535: Remove issues tables redundant indexes Hi Didier, I think this is good, but is there a reason not to fix the existing installations of this is causing an issue? We aim to keep the database structure in sync. There are handy methods for checking on the existence of an index in the updatedatabase script that could be useful here. Hi, (In reply to Katrin Fischer from comment #2) > Hi Didier, > > I think this is good, but is there a reason not to fix the existing > installations of this is causing an issue? We aim to keep the database > structure in sync. There are handy methods for checking on the existence of > an index in the updatedatabase script that could be useful here. Mostly reliability. I'm not sure testing on index name is enough, other index must exist, use the right columns, and it must be more restrictive than the deleted one. (In reply to didier from comment #3) > Hi, > (In reply to Katrin Fischer from comment #2) > > Hi Didier, > > > > I think this is good, but is there a reason not to fix the existing > > installations of this is causing an issue? We aim to keep the database > > structure in sync. There are handy methods for checking on the existence of > > an index in the updatedatabase script that could be useful here. > Mostly reliability. > I'm not sure testing on index name is enough, other index must exist, use > the right columns, and it must be more restrictive than the deleted one. Maybe remove them all and recreate then? We may remove 'bordate' index, it is not safe to use timestamp into an index. I cant find what it is for exactly. But with ORM use, this is likly to be useless. |