Summary: | Make basket.pl and cancelorder.pl use $order->cancel | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, lucas, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch refactors order cancelling code usage to prepare the ground for code cleanup.
|
Version(s) released in: |
20.11.00
|
Circulation function: | |||
Bug Depends on: | 26515 | ||
Bug Blocks: | 26579, 26580 | ||
Attachments: |
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel Bug 26577: Make basket.pl and cancelorder.pl use ->cancel |
Description
Tomás Cohen Arazi (tcohen)
2020-09-30 11:04:21 UTC
Created attachment 110993 [details] [review] Bug 26577: Make basket.pl and cancelorder.pl use ->cancel This patch makes the mentioned controller scripts use the new $order->cancel method instead of DelOrder. To test: 1. Apply this patches 2. Have a basket with some orders 3. Play with cancelling orders and removing baskets => SUCCESS: No behaviour change! => SUCCESS: No errors! 4. Sign off :-D Created attachment 111035 [details] [review] Bug 26577: Make basket.pl and cancelorder.pl use ->cancel This patch makes the mentioned controller scripts use the new $order->cancel method instead of DelOrder. To test: 1. Apply this patches 2. Have a basket with some orders 3. Play with cancelling orders and removing baskets => SUCCESS: No behaviour change! => SUCCESS: No errors! 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> It's great to see this scripts getting tidied up.. works as expected. Signing off Created attachment 111174 [details] [review] Bug 26577: Make basket.pl and cancelorder.pl use ->cancel This patch makes the mentioned controller scripts use the new $order->cancel method instead of DelOrder. To test: 1. Apply this patches 2. Have a basket with some orders 3. Play with cancelling orders and removing baskets => SUCCESS: No behaviour change! => SUCCESS: No errors! 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |