Summary: | OverDrive results can return false positives when searches contain CCL syntax | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, fridolin.somers, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.03
|
Circulation function: | |
Attachments: |
Bug 26578: Clean overdrive searches before passing to OD
Bug 26578: Clean overdrive searches before passing to OD Bug 26578: Clean overdrive searches before passing to OD Bug 26578: Clean overdrive searches before passing to OD Bug 26578: Clean overdrive searches before passing to OD |
Description
Nick Clemens (kidclamp)
2020-09-30 12:57:31 UTC
Created attachment 110987 [details] [review] Bug 26578: Clean overdrive searches before passing to OD This patch copies regex used in buildQuery to detect ccl code in queries, but here we adapt it to remove any ccl signifiers to ensure correct results from OD To test: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' 7 - Apply patch 8 - Reload the page, if spurious results now, they should be gone 9 - Perform a search that returns overdrive results 10 - For a title in overdrive search koha with: au:{Author} AND ti:{Title} 11 - Confirm overdrive results are returned 12 - Check the link to overdrive results and note query section is: q=Author AND Title Created attachment 113923 [details] [review] Bug 26578: Clean overdrive searches before passing to OD This patch copies regex used in buildQuery to detect ccl code in queries, but here we adapt it to remove any ccl signifiers to ensure correct results from OD To test: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' 7 - Apply patch 8 - Reload the page, if there were spurious results before, they should now be gone 9 - Perform a search that returns overdrive results 10 - For a title in overdrive search koha with: au:{Author} AND ti:{Title} 11 - Confirm overdrive results are returned 12 - Check the link to overdrive results and note query section is: q=Author AND Title Created attachment 114058 [details] [review] Bug 26578: Clean overdrive searches before passing to OD This patch copies regex used in buildQuery to detect ccl code in queries, but here we adapt it to remove any ccl signifiers to ensure correct results from OD To test: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' 7 - Apply patch 8 - Reload the page, if there were spurious results before, they should now be gone 9 - Perform a search that returns overdrive results 10 - For a title in overdrive search koha with: au:{Author} AND ti:{Title} 11 - Confirm overdrive results are returned 12 - Check the link to overdrive results and note query section is: q=Author AND Title Current status: Needs Signoff Created attachment 114098 [details] [review] Bug 26578: Clean overdrive searches before passing to OD This patch copies regex used in buildQuery to detect ccl code in queries, but here we adapt it to remove any ccl signifiers to ensure correct results from OD To test: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' 7 - Apply patch 8 - Reload the page, if there were spurious results before, they should now be gone 9 - Perform a search that returns overdrive results 10 - For a title in overdrive search koha with: au:{Author} AND ti:{Title} 11 - Confirm overdrive results are returned 12 - Check the link to overdrive results and note query section is: q=Author AND Title Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 116014 [details] [review] Bug 26578: Clean overdrive searches before passing to OD This patch copies regex used in buildQuery to detect ccl code in queries, but here we adapt it to remove any ccl signifiers to ensure correct results from OD To test: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' 7 - Apply patch 8 - Reload the page, if there were spurious results before, they should now be gone 9 - Perform a search that returns overdrive results 10 - For a title in overdrive search koha with: au:{Author} AND ti:{Title} 11 - Confirm overdrive results are returned 12 - Check the link to overdrive results and note query section is: q=Author AND Title Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks good to me. Cannot actually test OverDrive. Decoding html entities with DomParser is a recommended approach. This change will only affect people with OD enabled. No harm expected. Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Doesn't apply cleanly to 20.05, please rebase if needed |