Bug 26580

Summary: Remove unused C4::Acquisition::DelBasket function
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi <tomascohen>
Status: Pushed to master --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, lucas, martin.renvoize
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26579
Change sponsored?: --- Patch complexity: Trivial patch
Who signed the patch off: Manual merge request:
Text to go in the release notes:
Version(s) released in:
20.11.00
Bug Depends on: 26577    
Bug Blocks: 21204, 26584    
Attachments: Bug 26580: Remove unused C4::Acquisition::DelBasket function
Bug 26580: Remove unused C4::Acquisition::DelBasket function
Bug 26580: Remove unused C4::Acquisition::DelBasket function

Description Tomás Cohen Arazi 2020-09-30 15:02:21 UTC
As of bug 26577 it is no longer used in the codebase.
Comment 1 Tomás Cohen Arazi 2020-09-30 15:05:55 UTC
Created attachment 110997 [details] [review]
Bug 26580: Remove unused C4::Acquisition::DelBasket function

Bug 26577 removed the only use of it.

To test:
1. Apply this patch
2. Run:
   $ git grep DelBasket
=> SUCCESS: Only finds references to DelBasketGroup
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2020-10-01 13:17:47 UTC
Created attachment 111043 [details] [review]
Bug 26580: Remove unused C4::Acquisition::DelBasket function

Bug 26577 removed the only use of it.

To test:
1. Apply this patch
2. Run:
   $ git grep DelBasket
=> SUCCESS: Only finds references to DelBasketGroup
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2020-10-07 13:26:20 UTC
Created attachment 111331 [details] [review]
Bug 26580: Remove unused C4::Acquisition::DelBasket function

Bug 26577 removed the only use of it.

To test:
1. Apply this patch
2. Run:
   $ git grep DelBasket
=> SUCCESS: Only finds references to DelBasketGroup
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2020-10-07 13:27:42 UTC
Nice work, no trace of the method is found.

No regressions and QA script is happy (though it warns about the drop in POD coverage, which is expected).

Passing QA
Comment 5 Jonathan Druart 2020-10-15 13:25:32 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 6 Lucas Gass 2020-11-13 15:52:39 UTC
enhancement will not be backported to 20.05.x