| Summary: | Remove unused C4::Acquisition::DelBasket function | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26579 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 26577 | ||
| Bug Blocks: | 21204, 26584 | ||
| Attachments: |
Bug 26580: Remove unused C4::Acquisition::DelBasket function
Bug 26580: Remove unused C4::Acquisition::DelBasket function Bug 26580: Remove unused C4::Acquisition::DelBasket function |
||
|
Description
Tomás Cohen Arazi (tcohen)
2020-09-30 15:02:21 UTC
Created attachment 110997 [details] [review] Bug 26580: Remove unused C4::Acquisition::DelBasket function Bug 26577 removed the only use of it. To test: 1. Apply this patch 2. Run: $ git grep DelBasket => SUCCESS: Only finds references to DelBasketGroup 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 111043 [details] [review] Bug 26580: Remove unused C4::Acquisition::DelBasket function Bug 26577 removed the only use of it. To test: 1. Apply this patch 2. Run: $ git grep DelBasket => SUCCESS: Only finds references to DelBasketGroup 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 111331 [details] [review] Bug 26580: Remove unused C4::Acquisition::DelBasket function Bug 26577 removed the only use of it. To test: 1. Apply this patch 2. Run: $ git grep DelBasket => SUCCESS: Only finds references to DelBasketGroup 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice work, no trace of the method is found. No regressions and QA script is happy (though it warns about the drop in POD coverage, which is expected). Passing QA Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |