| Summary: | Add a choice to prevent the checkout or warn the user if CheckPrevCheckout is used via SIP2 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Koha Team University Lyon 3 <koha> |
| Component: | SIP2 | Assignee: | Matthias Meusburger <matthias.meusburger> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, colin.campbell, dcook, fridolin.somers, jheltibridle, jonathan.druart, koha, liz, m.de.rooy, martin.renvoize, matthias.meusburger |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Some libraries would like patrons to be able to check out items with prior checkouts via SIP even if the CheckPrevIssue preference is enabled.
This feature is enabled by adding the flag prevcheckout_block_checkout to an account in the SIP configuration file, and setting the value of it to "0".
|
Version(s) released in: |
21.05.00,20.11.04
|
| Circulation function: | |||
| Bug Depends on: | 19457 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents
Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents |
||
|
Description
Koha Team University Lyon 3
2020-10-01 09:03:03 UTC
Created attachment 112975 [details] [review] Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Created attachment 112986 [details] [review] Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Matthias, please provide a complete test plan. Prove is not enough here. Sure thing! Created attachment 112991 [details] [review] Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Enable the CheckPrevCheckout syspref (on "Do" for instance) 3) Enable prevcheckout_block_checkout in the SIP server config file 4) Checkout and checkin an item for a user 5) Checkout the item again with the SIP CLI tool 6) Check that the SIP message is "This item was previously checked out by you" and that the item was not checked out 7) Disable prevcheckout_block_checkout in the SIP server config file 8) Checkout the item again with the SIP CLI tool 9) Check that the SIP message is "This item was previously checked out by you" and that the item was checked out. 10) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> If I understand correctly, this SIP setting goes further than the corresponding system preference. My question is here: Should this be something only "hidden deeper" in the SIP config file, or should it actually be a system preference and have the same effect in the staff client ? (In reply to Marcel de Rooy from comment #6) > If I understand correctly, this SIP setting goes further than the > corresponding system preference. > My question is here: Should this be something only "hidden deeper" in the > SIP config file, or should it actually be a system preference and have the > same effect in the staff client ? One answer to this question can be the same that Kyle made here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541#c4 "The problem with a syspref though is that the behavior cannot be changed on a per-account basis. It very well may be that such behavior is desired for a self check machine for example, but not for an AMH." Created attachment 117210 [details] [review] Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Enable the CheckPrevCheckout syspref (on "Do" for instance) 3) Enable prevcheckout_block_checkout in the SIP server config file 4) Checkout and checkin an item for a user 5) Checkout the item again with the SIP CLI tool 6) Check that the SIP message is "This item was previously checked out by you" and that the item was not checked out 7) Disable prevcheckout_block_checkout in the SIP server config file 8) Checkout the item again with the SIP CLI tool 9) Check that the SIP message is "This item was previously checked out by you" and that the item was checked out. 10) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 117211 [details] [review] Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Enable the CheckPrevCheckout syspref (on "Do" for instance) 3) Enable prevcheckout_block_checkout in the SIP server config file 4) Checkout and checkin an item for a user 5) Checkout the item again with the SIP CLI tool 6) Check that the SIP message is "This item was previously checked out by you" and that the item was not checked out 7) Disable prevcheckout_block_checkout in the SIP server config file 8) Checkout the item again with the SIP CLI tool 9) Check that the SIP message is "This item was previously checked out by you" and that the item was checked out. 10) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This patch follows the same logic as bug 25541 and allows override of the CheckPrevIssue at the sip account level. Tested and working as expected with new unit tests passing. I've added the new option to the Wiki page as required (https://wiki.koha-community.org/wiki/SIP2_configuration) and fixed a tab character that was failing the QA script. Passing QA Pushed to master for 21.05, thanks to everybody involved! Small useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.04 Enhancement, not backported to 20.05 |