| Summary: | C4/RotatingCollections.pm should not use C4::Circulation::transferbook | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | https://gitlab.com/mrenvoize/Koha/-/tree/bug_22569 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement updates the Rotating Collections system to use the recently introduced Koha:: methods for Item Transfers.
We expose some extra feedback to the end user to highlight where transfers would have previously failed silently when used in combination with other systems that trigger transfers.
|
Version(s) released in: |
21.05.00
|
| Circulation function: | |||
| Bug Depends on: | 24446 | ||
| Bug Blocks: | 22569 | ||
| Attachments: |
Bug 26618: Remove use of transferbook in RotatingCollections
Bug 26618: Remove use of transferbook in RotatingCollections Bug 26618: Remove use of transferbook in RotatingCollections Bug 26618: Remove use of transferbook in RotatingCollections Bug 26618: (QA follow-up) Update messages syntax Bug 26618: (QA follow-up) Fix unit test for TranferCollection change Bug 26618: Improve Exception Class Names |
||
|
Description
Martin Renvoize (ashimema)
2020-10-06 10:58:10 UTC
Created attachment 111305 [details] [review] Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. Created attachment 111313 [details] [review] Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. We also introduce additional feedback for the end user where it did not exist before. Now we notify the user if some of the collection could not be transfers or if transfers were queued rather than set to request immediately. Test plan 1/ Set up a rotating collection 2/ Transfer the collection 3/ Confirm the action succeeds 4/ Set up some branch transfer limits that will affect items in your collection 5/ Transfer the collection 6/ Note that the transfer succeeds but some items are returned as failures Please test this as part of the bug 22569 tree linked above. BLOCKED by dependent bug. Created attachment 116571 [details] [review] Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. We also introduce additional feedback for the end user where it did not exist before. Now we notify the user if some of the collection could not be transfers or if transfers were queued rather than set to request immediately. Test plan 1/ Set up a rotating collection 2/ Transfer the collection 3/ Confirm the action succeeds 4/ Set up some branch transfer limits that will affect items in your collection 5/ Transfer the collection 6/ Note that the transfer succeeds but some items are returned as failures Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 117608 [details] [review] Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. We also introduce additional feedback for the end user where it did not exist before. Now we notify the user if some of the collection could not be transfers or if transfers were queued rather than set to request immediately. Test plan 1/ Set up a rotating collection 2/ Transfer the collection 3/ Confirm the action succeeds 4/ Set up some branch transfer limits that will affect items in your collection 5/ Transfer the collection 6/ Note that the transfer succeeds but some items are returned as failures Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 117609 [details] [review] Bug 26618: (QA follow-up) Update messages syntax As highlighted, we were not using the standard form of message passing here. This patch updates the template and controller to adopt the more usual syntax. Created attachment 117610 [details] [review] Bug 26618: (QA follow-up) Fix unit test for TranferCollection change We update TransferCollection to use the settled upon standard for passing error messages back from a method. This patch updates the corresponding unit test. Created attachment 117611 [details] [review] Bug 26618: Improve Exception Class Names Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |