Description
Nick Clemens (kidclamp)
2020-10-07 12:41:53 UTC
Created attachment 123368 [details] [review] Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Created attachment 123373 [details]
Dialog with revised icons
I think the minus symbol isn't very understandable. What about using the "trash" icon (which we use in other situations for "delete") for the cancel operation? See the attached mockup.
I like the idea of promoting icon consistency. I'm happy to defer to Owen on questions of minuses and garbage cans :) (In reply to Owen Leonard from comment #2) > Created attachment 123373 [details] > Dialog with revised icons > > I think the minus symbol isn't very understandable. What about using the > "trash" icon (which we use in other situations for "delete") for the cancel > operation? See the attached mockup. That sounds good to me! Did you code it already, or shall I attempt? I don't have a patch, so please attempt! Created attachment 123462 [details] [review] Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. (In reply to Owen Leonard from comment #5) > I don't have a patch, so please attempt! Never mind I did a patch! Created attachment 123698 [details] [review] Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 123699 [details] [review] Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> This works and the visual presentation is very clear. I like using the x for Ignore and the trash can for Cancel. Please rebase. Created attachment 139470 [details] [review] Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 139471 [details] [review] Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 139472 [details] [review] Bug 26626: (follow-up) Be consistent with icon and accesskeys Created attachment 139540 [details] [review] Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Created attachment 139541 [details] [review] Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Created attachment 139542 [details] [review] Bug 26626: (follow-up) Be consistent with icon and accesskeys Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.07 release applied to 21.11.x for 21.11.14 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. |