| Summary: | Add translation context to cancel hold button in OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Timothy Alexis Vass <timothy_alexis.vass> |
| Component: | OPAC | Assignee: | Timothy Alexis Vass <timothy_alexis.vass> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | aleisha, caroline.cyr-la-rose, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 26647 - The Cancel button in holds table should be translated in context for Swedish
Bug 26647 - The Cancel button in holds table should be translated in context for Swedish Bug 26647: Add translation context to cancel hold button in OPAC Bug 26647: Add translation context to cancel hold button in OPAC |
||
|
Description
Timothy Alexis Vass
2020-10-09 14:52:57 UTC
Created attachment 111415 [details] [review] Bug 26647 - The Cancel button in holds table should be translated in context for Swedish 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off It worked, but the msgid and the msgctxt in my sv-SE-messages.po seem to be inverted?
169 msgctxt "Cancel"
170 msgid "Cancel hold button"
171 msgstr "aaaaaaaa"
(don't mind the aaaa, I put something silly just to make sure I noticed if it worked, hehe).
It should be msgctxt Cancel hold button and msgid Cancel.
But it works, so I'm not sure.
I think in your holds-table.inc, you should write it in this order
[% tp('Cancel hold button','Cancel') | html %]
Created attachment 111465 [details] [review] Bug 26647 - The Cancel button in holds table should be translated in context for Swedish 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off (In reply to Caroline Cyr La Rose from comment #2) > It worked, but the msgid and the msgctxt in my sv-SE-messages.po seem to be > inverted? Thank you Caroline. :) Correct patch is now attached. Created attachment 111546 [details] [review] Bug 26647: Add translation context to cancel hold button in OPAC 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 111563 [details] [review] Bug 26647: Add translation context to cancel hold button in OPAC 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Same issue in German - will be happy to get rid of a little more jQuery :) Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.06 doesn't apply cleanly to 19.11.x, please rebase |