Bug 26651

Summary: Add Koha::Object->reset_messages
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: agustinmoyano, jonathan.druart, julian.maurice, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26652
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 26555    
Bug Blocks:    
Attachments: Bug 26651: Add ->reset_messages

Description Tomás Cohen Arazi 2020-10-09 17:42:53 UTC
This method was originally introduced as part of bug 26555. But it was not clear if it was required, or even if some more complex mechanism for marking 'seen' messages is required.

I'm leaving this specific patch here for discussing it once someone finds a real need for it.
Comment 1 Tomás Cohen Arazi 2020-10-09 17:48:32 UTC
Created attachment 111425 [details] [review]
Bug 26651: Add ->reset_messages

This patch was orginally part of bug 26555, and introduces a method for
cleaning the accumulated messages.

The idea is that you might run:

    $patron->some
           ->series
           ->of
           ->method
           ->calls;

    if ( $patron->messages ) { ... }

and for next calls, want the messages cleared. So you can call

    $patron->reset_messages;

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 2 Tomás Cohen Arazi 2022-03-09 13:21:31 UTC
*** Bug 26650 has been marked as a duplicate of this bug. ***