Would it already help to wrap the received in a span with a class for easier styling? Maybe it's also time to change "rcvd" to "received" (for English clarity and ease of translation for non-English users)? I think wrapping in a span for easier styling would be great. Good suggestion to change the wording to "received" which is more clear and improving ease of translation is a bonus too. Created attachment 111943 [details] [review] Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source In the 5th step, when I click on Receive I'm getting the error - "Template process failed: undef error - The method Koha::Item->size is not covered by tests!" which is followed by lots of details about the error. (In reply to Barbara Johnson from comment #5) > In the 5th step, when I click on Receive I'm getting the error - "Template > process failed: undef error - The method Koha::Item->size is not covered by > tests!" which is followed by lots of details about the error. Hi Barbara, I wonder if this is related to the patch as I haven't touched the receive process, only the basket summary page. If you can, could you repeat the tests with out the patch? Did you create items on order? Receiving items is broken for me too - independent of this patch :( I filed bug 26730. Created attachment 112054 [details] [review] Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 112076 [details] [review] Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 112105 [details] [review] Bug 26680: Acq - Wrap (rcvd) in a span and change text to received The new span with the class order-received will allow to have individual styling on the term to make it stand out more in the list of order lines of a basket. The text change will ease translation. To test: - In acquisitions: - Create a new basket - Add at least 2 order lines - Close the basket - Receive a new shipment and one of your order lines - Go back to your basket - One line should now show "(rcvd)" - Apply patch - Reload the basket page - Verify the text has changed and element now has a class in the HTML source Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice little enhancement, works well.. Passing QA Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |
Created attachment 111638 [details] Title in basket with (rcvd) displayed in red When viewing a basket of titles on basket.pl it would helpful to highlight the (rcvd) info for ease of use and efficiency. We currently use some jQuery (created for us by George Williams at NEKLS) to make ours red so that it stands out. But I think it would great if this could be incorporated into Koha. Example: (rcvd) All the devils are here / by Penny, Louise. jQuery we're using: $("#acqui_basket_content p:contains('(rcvd)')").html(function(_, html) { return html.replace(/(rcvd)/g, '<span style="font-weight: bold; color: #990000;">$1</span>'); });