Summary: | Radio Buttons where there should be checkboxes on Dictionary | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Reports | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P3 | CC: | brendan, chris, f.demians, jonathan.druart, julian.maurice, kyle, oleonard, veron |
Version: | Main | ||
Hardware: | PC | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 15557 | ||
Attachments: |
radio buttons
screenshot Bug 2669: Change checkboxes to radio buttons on dictionary Bug 2669: Change checkboxes to radio buttons on dictionary Bug 2669: Change checkboxes to radio buttons on dictionary Bug 2669: Change checkboxes to radio buttons on dictionary |
Description
Chris Cormack
2010-05-21 00:54:29 UTC
Created attachment 8794 [details]
screenshot
I tried retesting this on current master, what I did:
1) New definition
2) Module: patrons
3) Registration date
4) Nothing shows up for the 4th step
For other dates like 'Expiry date' the 4th step shows up correctly and shows the wrong behaviour Nicole described.
(In reply to Katrin Fischer from comment #1) > Created attachment 8794 [details] > screenshot > > I tried retesting this on current master, what I did: > > 1) New definition > 2) Module: patrons > 3) Registration date > 4) Nothing shows up for the 4th step > > For other dates like 'Expiry date' the 4th step shows up correctly and shows > the wrong behaviour Nicole described. With current master 'Expiry date' displays on current master, but the bug as such is still valid. Created attachment 46482 [details] [review] Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... (In reply to Jonathan Druart from comment #3) (...) > Note that I don't understand what means 'All dates', there is no > condition generated for the dictionary. We should not have to select a > field if we don't want to add a condition on it :) Same findings with my tests: If "All dates" is set, the definition saves with an empty condition. (With and without patch, see dictionary.pl line 152.) To have a condition saved, "Date range" and at least one of the dates "Start of date range" and/or "End of date range" has to be set. Conclusion: The checkboxes rsp. radio buttons and the condition for their value in dictionary.pl line 152 could be removed. Created attachment 46505 [details] [review] Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Looks so much nicer too! Jonathan and Aleisha, Since the radio buttons do not make much sense, couldn't we simply remove them? (See test and conclusion on comment #4) (In reply to Marc Véron from comment #6) > Jonathan and Aleisha, > > Since the radio buttons do not make much sense, couldn't we simply remove > them? (See test and conclusion on comment #4) I would prefer another bug report, it won't be as easy as this patch. Created attachment 46515 [details] [review] Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Looks so much nicer too! Radio buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 46716 [details] [review] Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Looks so much nicer too! Radio buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Another wishlist item: it would be nice of the date range fields only displayed when the date range option is selected, or the date range option is selected automatically if the date range gets filled in my the librarian. Pushed to Master - Should be in the May 2016 Release. (Also would be cool to notes Kyle's wish list at the end of this.) Patch pushed to 3.22.x, will be in 3.22.3 This patch has been pushed to 3.20.x, will be in 3.20.9. |