| Summary: | Set focus for cursor to login box on the login popup modal | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barbara Johnson <barbara.johnson> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 26695: Add modal "shown" event to set cursor focus
Bug 26695: Add modal "shown" event to set cursor focus Bug 26695: Add modal "shown" event to set cursor focus |
||
|
Description
Barbara Johnson
2020-10-15 16:10:47 UTC
Created attachment 112001 [details] [review] Bug 26695: Add modal "shown" event to set cursor focus This patch attaches a focus() call to the login modal's "shown.bs.modal" event so that the cursor focus is set to the username field when the login modal is displayed. To test, apply the patch and confirm that your OPAC uses the regular login process--not casAuthentication or GoogleOpenIDConnect. Click the "Log in to your account" link in the header. A the login form should appear in a modal dialog, and the focus should be on the username field. The same should be true if you trigger the modal from other locations, for instance: "Log in to add tags" on the bibliographic detail page or the tag cloud page. Created attachment 112008 [details] [review] Bug 26695: Add modal "shown" event to set cursor focus This patch attaches a focus() call to the login modal's "shown.bs.modal" event so that the cursor focus is set to the username field when the login modal is displayed. To test, apply the patch and confirm that your OPAC uses the regular login process--not casAuthentication or GoogleOpenIDConnect. Click the "Log in to your account" link in the header. A the login form should appear in a modal dialog, and the focus should be on the username field. The same should be true if you trigger the modal from other locations, for instance: "Log in to add tags" on the bibliographic detail page or the tag cloud page. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 112035 [details] [review] Bug 26695: Add modal "shown" event to set cursor focus This patch attaches a focus() call to the login modal's "shown.bs.modal" event so that the cursor focus is set to the username field when the login modal is displayed. To test, apply the patch and confirm that your OPAC uses the regular login process--not casAuthentication or GoogleOpenIDConnect. Click the "Log in to your account" link in the header. A the login form should appear in a modal dialog, and the focus should be on the username field. The same should be true if you trigger the modal from other locations, for instance: "Log in to add tags" on the bibliographic detail page or the tag cloud page. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |