Summary: | Make payment table has a display issue when credits exist | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, lucas, martin.renvoize |
Version: | master | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.06
|
|
Attachments: |
Make payment tab in patron account in staff interface
Bug 26696: Fix colspan in payment table when credit exists Bug 26696: Fix colspan in payment table when credit exists Bug 26696: Fix colspan in payment table when credit exists |
Created attachment 111818 [details] [review] Bug 26696: Fix colspan in payment table when credit exists The colspan was adjusted for the total due when a new column was added to the table, but the 2 lines for credits were missed. To test: - Go to any patron account - Create a manual invoice - Create a credit - Go to the 'Make a payment' tab - Veriy that the total lines at the bottom of the table are slightly off - Apply the patch - Verify that the total lines in the table now display correctly Created attachment 112661 [details] [review] Bug 26696: Fix colspan in payment table when credit exists The colspan was adjusted for the total due when a new column was added to the table, but the 2 lines for credits were missed. To test: - Go to any patron account - Create a manual invoice - Create a credit - Go to the 'Make a payment' tab - Veriy that the total lines at the bottom of the table are slightly off - Apply the patch - Verify that the total lines in the table now display correctly Signed-off-by: David Nind <david@davidnind.com> What's the attached image for Katrin? Created attachment 112860 [details] [review] Bug 26696: Fix colspan in payment table when credit exists The colspan was adjusted for the total due when a new column was added to the table, but the 2 lines for credits were missed. To test: - Go to any patron account - Create a manual invoice - Create a credit - Go to the 'Make a payment' tab - Veriy that the total lines at the bottom of the table are slightly off - Apply the patch - Verify that the total lines in the table now display correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected.. Passing QA (In reply to Martin Renvoize from comment #3) > What's the attached image for Katrin? Oops, obviously not the right picture, but at least just a strange bugzilla screenshot! Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.06 can't reproduce in 19.11.x, not backported |
Created attachment 111775 [details] Make payment tab in patron account in staff interface The totals are off by one cell in the "make payment" tab on the staff side. See screenshot.