|
Description
David Cook
2020-10-16 00:22:28 UTC
It actually looks like there are quite a few tests there... maybe they should be moved into the t/SIP directory... From bug 9848 comment 9 """ They arnt a test suite they are a reminder that one needs to be written """ (In reply to Jonathan Druart from comment #2) > From bug 9848 comment 9 > > """ > They arnt a test suite they are a reminder that one needs to be written > """ But then it seems like Adrien was running them at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848#c0? I wonder if there is anyone at BibLibre who can speak to that... Created attachment 151960 [details] [review] Bug 26700: Remove unused C4/SIP/t directory This patch removes the unused C4/SIP/t directory. Created attachment 151965 [details] [review] Bug 26700: Remove unused C4/SIP/t directory This patch removes the unused C4/SIP/t directory. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 151966 [details] [review] Bug 26700: Remove occurrences in Makefile.PL As well as other 2 non existing paths (In reply to David Cook from comment #1) > It actually looks like there are quite a few tests there... maybe they > should be moved into the t/SIP directory... You just remove, not move. Did you check if there are some useful tests that we do not want to loose here? And they probably need quite a bit of editing too if we want to move them.. How did you verify that they are not being used? @Kyle: Are you aware of people using these tests ? (In reply to Marcel de Rooy from comment #7) > You just remove, not move. Did you check if there are some useful tests that > we do not want to loose here? And they probably need quite a bit of editing > too if we want to move them.. > > How did you verify that they are not being used? I raised this ticket and linked to existing tickets over 2 years ago, and no one ever replied. These tests aren't run by the official Koha test suite. If anyone uses them in an unofficial capacity, I'm sure they'll raise a ticket to say so after they're removed. (If they're running them, they're probably also someone with the capacity to do the work of editing them and moving them into the t/ or xt/ directories.) As Jonathan noted in 2021, Colin also commented in 2015 that he couldn't determine that anyone ran these tests or that anyone felt confident in working on them. Since we have the git history and it wouldn't affect production installations, I think we can remove these tests, and then we'll really be able to verify if anyone uses them. (In reply to Marcel de Rooy from comment #7) > (In reply to David Cook from comment #1) > > It actually looks like there are quite a few tests there... maybe they > > should be moved into the t/SIP directory... > > You just remove, not move. Did you check if there are some useful tests that > we do not want to loose here? And they probably need quite a bit of editing > too if we want to move them.. > > How did you verify that they are not being used? > > @Kyle: Are you aware of people using these tests ? I am not aware of anyone using these tests. We don't run them and avoid them due to their flakiness. I always choose to add unit tests to /t and avoid these ones altogether. Created attachment 152295 [details] [review] Bug 26700: Remove unused C4/SIP/t directory This patch removes the unused C4/SIP/t directory. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 152296 [details] [review] Bug 26700: Remove occurrences in Makefile.PL As well as other 2 non existing paths Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to David Cook from comment #8) > > Since we have the git history and it wouldn't affect production > installations, I think we can remove these tests, and then we'll really be > able to verify if anyone uses them. A few weeks later, we are all ready to go :) Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Not pushing to 22.11.x |