Summary: | Remove scripts from C4/SIP directory | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | SIP2 | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, colin.campbell, fridolin.somers, jonathan.druart, kyle, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 26701: Remove unused C4/SIP scripts
Bug 26701: Remove unused C4/SIP scripts Bug 26701: Remove unused C4/SIP scripts |
Description
David Cook
2020-10-16 00:26:06 UTC
There don't bring much, I am in favour of removing them. At least C4/SIP/interactive_renew_all_dump.pl is broken since commit d85f757ce7bf446705a8d76bc0d2280705a2d88d Date: Thu Oct 30 15:36:09 2014 +0000 Bug 7904 Change SIP modules to use standard LIB path Kyle, Colin, are you using them? (In reply to Jonathan Druart from comment #1) > There don't bring much, I am in favour of removing them. > > At least C4/SIP/interactive_renew_all_dump.pl is broken since > commit d85f757ce7bf446705a8d76bc0d2280705a2d88d > Date: Thu Oct 30 15:36:09 2014 +0000 > Bug 7904 Change SIP modules to use standard LIB path > > Kyle, Colin, are you using them? I can state confidently that I didn't even know about this script :) (In reply to Kyle M Hall from comment #2) > I can state confidently that I didn't even know about this script :) I'm glad that I'm not the only one who didn't know that these existed! (Koha is so big O_O.) Created attachment 114921 [details] [review] Bug 26701: Remove unused C4/SIP scripts Those scripts are not known to be used, we can remove them from the Koha codebase. Test plan: Confirm that the scripts removed by this patch are not used anywhere from Koha. Created attachment 115012 [details] [review] Bug 26701: Remove unused C4/SIP scripts Those scripts are not known to be used, we can remove them from the Koha codebase. Test plan: Confirm that the scripts removed by this patch are not used anywhere from Koha. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I've never used any of these.. they look to be from early development testing to me. Signing off. Created attachment 115021 [details] [review] Bug 26701: Remove unused C4/SIP scripts Those scripts are not known to be used, we can remove them from the Koha codebase. Test plan: Confirm that the scripts removed by this patch are not used anywhere from Koha. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! I propose to skip backport on stable branches. |