Summary: | Remove explicit libnet-stomp-perl from debian/control.in | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Packaging | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas, martin.renvoize, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Circulation function: | |||
Bug Depends on: | 22417 | ||
Bug Blocks: | |||
Attachments: |
Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in
Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in |
Description
David Cook
2020-10-16 00:57:53 UTC
Created attachment 111824 [details] [review] Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in libnet-stomp-perl is added to debian/control via __AUTODEPENDS__, so we don't need to add it manually into debian/control.in Created attachment 111836 [details] [review] Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in libnet-stomp-perl is added to debian/control via __AUTODEPENDS__, so we don't need to add it manually into debian/control.in Signed-off-by: Mason James <mtj@kohaaloha.com> Created attachment 111876 [details] [review] Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in libnet-stomp-perl is added to debian/control via __AUTODEPENDS__, so we don't need to add it manually into debian/control.in Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This all makes perfect sense.. Passing QA (In reply to David Cook from comment #0) > libnet-stomp-perl is added to debian/control via __AUTODEPENDS__, so we > don't need to add it manually into debian/control.in Mason, are you sure this is correct? Isn't control auto-generated from control.in? (In reply to Jonathan Druart from comment #5) > (In reply to David Cook from comment #0) > > libnet-stomp-perl is added to debian/control via __AUTODEPENDS__, so we > > don't need to add it manually into debian/control.in > > Mason, are you sure this is correct? Isn't control auto-generated from > control.in? control is auto-generated from control.in, but control.in is also updated by replacing __AUTODEPENDS__ with the output of debian/list-deps, which sources the dependencies from the "cpanfile", which contains Net::Stomp. Mason, not directly related to this patch but, I wanted to push the changes to debian/control along with this patch and I have: - libreadonly-xs-perl, and + libtest-harness-perl, Should we deal with them on a separate bug report? Is that new or something you are aware of already? Pushed to master for 20.11, thanks to everybody involved! missing dependencies for 20.05.x, no backport |