Bug 26725

Summary: Improve link text on Patron attributes administration page
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Tal Rogoff <tal.rogoff>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: aleisha, alexbuckley, david, jonathan.druart
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.06
Bug Depends on:    
Bug Blocks: 26722    
Attachments: bug 26725: changed the text of the "here" link on the patron attributes administration page
bug 26725: link text changed to just system preference name. "system preference" put in sentence case.
bug 26725: changed the text of the "here" link on the patron attributes administration page
bug 26725: link text changed to just system preference name. "system preference" put in sentence case.
Bug 26725: changed the text of the "here" link on the patron attributes administration page
Bug 26725: link text changed to just system preference name. "system preference" put in sentence case.
Bug 26725: (QA follow-up) Add line break and 'the' for readability

Description Katrin Fischer 2020-10-18 15:48:45 UTC
There is a link labelled "here" that should be improved on the patron attributes page.

To test:
- Set ExtendedPatronAttributes system preference to "Don't enable"
- Go to Administration > Patron attribute types

The "here" link in the blue box at the top of the page should have a more meaningful link text.
Comment 1 Alex Buckley 2020-10-23 22:22:41 UTC
Created attachment 112314 [details] [review]
bug 26725: changed the text of the "here" link on the patron attributes administration page

test plan:
1. set ExtendedPatronAttributes system preferences to "Don't enable"
2. go to Administration > Patron attribute types
3. the link text of "here" is displayed in the blue box at the top of
the page
4. apply the patch
5. refresh the page
6. notice the link text has changed to "ExtendedPatronAttributes System
Preference"
Comment 2 David Nind 2020-10-23 22:39:21 UTC
This all works as per the test plan, but I would:

- just link the system preference name
- put system preference in sentence case.

A nice improvement and gets rid of the 'click here' type links!
Comment 3 Alex Buckley 2020-10-23 22:51:20 UTC
Created attachment 112315 [details] [review]
bug 26725: link text changed to just system preference name. "system preference" put in sentence case.
Comment 4 Alex Buckley 2020-10-23 22:52:42 UTC
Attached patch that fixes your notes in comment #2. Could you please test again?
Comment 5 David Nind 2020-10-23 23:18:49 UTC
Created attachment 112319 [details] [review]
bug 26725: changed the text of the "here" link on the patron attributes administration page

test plan:
1. set ExtendedPatronAttributes system preferences to "Don't enable"
2. go to Administration > Patron attribute types
3. the link text of "here" is displayed in the blue box at the top of
the page
4. apply the patch
5. refresh the page
6. notice the link text has changed to "ExtendedPatronAttributes System
Preference"

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2020-10-23 23:18:56 UTC
Created attachment 112320 [details] [review]
bug 26725: link text changed to just system preference name. "system preference" put in sentence case.

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Nick Clemens (kidclamp) 2020-10-24 00:43:19 UTC
Created attachment 112343 [details] [review]
Bug 26725: changed the text of the "here" link on the patron attributes administration page

test plan:
1. set ExtendedPatronAttributes system preferences to "Don't enable"
2. go to Administration > Patron attribute types
3. the link text of "here" is displayed in the blue box at the top of
the page
4. apply the patch
5. refresh the page
6. notice the link text has changed to "ExtendedPatronAttributes System
Preference"

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens (kidclamp) 2020-10-24 00:43:25 UTC
Created attachment 112344 [details] [review]
Bug 26725: link text changed to just system preference name. "system preference" put in sentence case.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Nick Clemens (kidclamp) 2020-10-24 00:43:31 UTC
Created attachment 112345 [details] [review]
Bug 26725: (QA follow-up) Add line break and 'the' for readability

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Alex Buckley 2020-10-24 01:29:38 UTC
Now Tal has a Bugzilla account, I'll set her as the assignee :)
Comment 11 Jonathan Druart 2020-10-25 23:08:48 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 12 Jonathan Druart 2020-10-25 23:18:31 UTC
Congratulations Tal for your first patch pushed!
Comment 13 Aleisha Amohia 2020-11-17 05:05:59 UTC
enhancement, not backported to 19.11.x
Comment 14 Aleisha Amohia 2020-11-17 20:47:26 UTC
Lucas has also backported this to 20.05.x for 20.05.06