Bug 26749

Summary: Correct dropdown markup in OPAC cart
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00
Bug Depends on: 20168    
Bug Blocks:    
Attachments: Bug 26749: Correct dropdown markup in OPAC cart
Bug 26749: Correct dropdown markup in OPAC cart
Bug 26749: Correct dropdown markup in OPAC cart

Description Owen Leonard 2020-10-20 11:57:25 UTC
The download menu in the OPAC cart has incorrect markup. I missed it during the upgrade to Bootstrap 4.
Comment 1 Owen Leonard 2020-10-20 12:04:43 UTC
Created attachment 112029 [details] [review]
Bug 26749: Correct dropdown markup in OPAC cart

This patch corrects the markup of the "Download" dropdown menu in the
OPAc cart. It was not updated during the upgrade to Bootstrap 4.

To test, apply the patch and perform a catalog search in the OPAC.

- Add some titles to the cart.
- Open the cart and test the "Download" menu button.
- The menu should display correctly, and the menu items should work to
  download the correct files.
Comment 2 Lucas Gass 2020-10-22 14:08:50 UTC
Created attachment 112198 [details] [review]
Bug 26749: Correct dropdown markup in OPAC cart

This patch corrects the markup of the "Download" dropdown menu in the
OPAc cart. It was not updated during the upgrade to Bootstrap 4.

To test, apply the patch and perform a catalog search in the OPAC.

- Add some titles to the cart.
- Open the cart and test the "Download" menu button.
- The menu should display correctly, and the menu items should work to
  download the correct files.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2020-10-22 22:11:44 UTC
Created attachment 112221 [details] [review]
Bug 26749: Correct dropdown markup in OPAC cart

This patch corrects the markup of the "Download" dropdown menu in the
OPAc cart. It was not updated during the upgrade to Bootstrap 4.

To test, apply the patch and perform a catalog search in the OPAC.

- Add some titles to the cart.
- Open the cart and test the "Download" menu button.
- The menu should display correctly, and the menu items should work to
  download the correct files.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-10-25 23:09:10 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-11-13 21:03:22 UTC
missing dependencies for 20.05.x, no backport